Fix DTD validation: Add required tbody elements to tables with thead#39
Merged
findbhavin merged 4 commits intomainfrom Jan 22, 2026
Merged
Fix DTD validation: Add required tbody elements to tables with thead#39findbhavin merged 4 commits intomainfrom
findbhavin merged 4 commits intomainfrom
Conversation
Co-authored-by: findbhavin <19400906+findbhavin@users.noreply.github.com>
Co-authored-by: findbhavin <19400906+findbhavin@users.noreply.github.com>
Co-authored-by: findbhavin <19400906+findbhavin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix DTD validation error for table formatting in XML/HTML files
Fix DTD validation: Add required tbody elements to tables with thead
Jan 22, 2026
findbhavin
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tables with
<thead>were failing DTD validation due to missing required<tbody>elements. The error:expecting ((col* | colgroup*), ((thead?, tfoot?, tbody+) | tr+)), got (colgroup thead).Root Cause
MasterPipeline._post_process_xml()explicitly skipped adding<tbody>for tables with multiple thead rows to avoid empty rows in HTML output, violating JATS DTD requirements.Changes
MasterPipeline.py (lines 980-1011)
<tbody>when<thead>exists but no<tbody>presentcolgrouportheadand applycolspanto empty tbody celltests/test_table_and_article_type_fixes.py
test_tables_with_thead_have_tbodyto verify DTD compliancetest_html_tables_no_empty_rows_at_endto accept minimal tbody as DTD-requiredExample
Before:
After:
Result
All 5 tables in generated XML now conform to DTD structure requirements with appropriate colspan attributes (2, 13, 12, 11, 3 columns respectively).
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This pull request was created from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.