Add distro resources / handle files correctly in 22-image.raku#113
Add distro resources / handle files correctly in 22-image.raku#113finanalyst merged 8 commits intofinanalyst:masterfrom
Conversation
This requires a few new GDK related subs. I have placed them within GTK::Simple::Raw instead of GTK::Simple::GDK because otherwise we would need to import the latter into the former. Since these new routines are only used by GTK::Simple::Image, it seems fine to group them in Raw where they are imported via the :image import set.
In order to have a correct example for the new `GTK::Simple::Image`, we need to use the `%?RESOURCES` of the `GTK::Simple` distribution. This is exposed via: GTK::Simple::Distro::Resources::gtk-simple-resources This is declared as a term so that once imported, you can access the returned hash easily: gtk-simple-resources<camelia-logo.png>.slurp(:bin, :close) This will hopefully be useful for users to some degree, but it is primarily added for examples to access.
META6.json
Outdated
| "finanalyst aka Richard Hainsworth" | ||
| ], | ||
| "auth": "zef:finanalyst", | ||
| "depends": [ |
There was a problem hiding this comment.
Feels this should somehow be conditional?
|
@ab5tract Any idea why the checks are failing? I think may be we should do the test with a pre-compiled docker image. |
|
Maybe try an |
|
@dwarring I've added |
|
@ab5tract I tried re-running the test, but its not using the new work flow file. |
|
@ab5tract one of the tests failed [/t/02-export-subs.rakutest] |
|
@ab5tract The automatic testing fails on |
|
@ab5tract |
|
@finanalyst i am aware. What's the purpose of pinging like this? |
|
@ab5tract sorry! I didnt think you had heard me. |
|
That's alright. I need to try this on Linux to determine if it actually passes locally or not. |
|
@ab5tract I just re-read issue #112 and your response. Is the test failure here due to the same reason as the failures in #112? I haven't analysed the problem yet. If the failures are independent of the work in this PR, then I can merge this PR, and then we could have a separate PR to handle the example failures Your thoughts? |
|
@ab5tract Fab! |
|
This is one time at least that it's very handy that you can pass unused named arguments to methods :) |
Some relevant commit messages:
and