Skip to content

Fix #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
revolutionkpi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6860839
Fix
michaelsergienko Aug 7, 2020
f9ea1ae
Fix
michaelsergienko Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CardsCollectionViewLayout.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ open class CardsCollectionViewLayout: UICollectionViewLayout {
override open func layoutAttributesForElements(in rect: CGRect) -> [UICollectionViewLayoutAttributes]? {
let totalItemsCount = collectionView.numberOfItems(inSection: 0)

let minVisibleIndex = max(Int(collectionView.contentOffset.x) / Int(collectionView.bounds.width), 0)
var minVisibleIndex = max(Int(collectionView.contentOffset.x) / Int(collectionView.bounds.width), 0)
let maxVisibleIndex = min(minVisibleIndex + maximumVisibleItems, totalItemsCount)

let contentCenterX = collectionView.contentOffset.x + (collectionView.bounds.width / 2.0)
Expand All @@ -59,6 +59,11 @@ open class CardsCollectionViewLayout: UICollectionViewLayout {

let percentageDeltaOffset = CGFloat(deltaOffset) / collectionView.bounds.width

// ToDO: fix crash
Copy link
Owner

@filletofish filletofish Aug 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove todo please?

if minVisibleIndex > totalItemsCount {
minVisibleIndex = totalItemsCount
}
Comment on lines +63 to +65
Copy link
Owner

@filletofish filletofish Aug 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why minVisibleIndex could be larger than totalItemsCount ? Does this happen when collectionView.contentOffset.x is too large? Could it be that the real root cause is in the different place?


let visibleIndices = stride(from: minVisibleIndex, to: maxVisibleIndex, by: 1)

let attributes: [UICollectionViewLayoutAttributes] = visibleIndices.map { index in
Expand Down