Conversation
willscott
force-pushed
the
feat/include-root
branch
from
23ec969 to
5d20703
Compare
Contributor
Author
|
(complementary PR is ipld/go-car#461 which makes parsing more lenient) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
+ Coverage 76.21% 76.34% +0.12%
==========================================
Files 85 85
Lines 6394 6395 +1
==========================================
+ Hits 4873 4882 +9
+ Misses 1249 1243 -6
+ Partials 272 270 -2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #354
This is a somewhat naive fix, but i don't think it's totally unreasonable.
If you ask for
/ipfs/<cid>/path/to/filethe root of the car you get back will, with this change, be
<cid>.I think the complexity that led to the current structure was a desire to have the root cid be
file, but for validation and since the response car has blocks that are parents offile, it doesn't seem "incorrect" to say that therootof the structure in the car is<cid>.ref: ipfs/specs#402 (comment)