This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Open
Conversation
Contributor
Author
|
see part 1 of #60 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spot check please:
we had made a mistake in how the sim treated tipsets, whereby null blocks were used as tipsets (breaking the abstraction that they are just more tickets in the array).
The consequence here was this:
take blocks C and D, both mined on top of a null block, themselves both mined on top of a tipset made of blocks A and B. C and D can be assembled into a tipset by a new block E but were not as E was seeing their parents as the null blocks rather than A and B.
The rule is in fact:
Replaced this.