check if plugin called with valid file path string#12
Open
lukebfunk wants to merge 2 commits intofiji:masterfrom
Open
check if plugin called with valid file path string#12lukebfunk wants to merge 2 commits intofiji:masterfrom
lukebfunk wants to merge 2 commits intofiji:masterfrom
Conversation
Useful for enabling drag-and-drop open by adding HDF_Reader_Vibez in HandleExtraFileTypes.java within IO as default for hdf files
Member
|
@rejsmont Do you have time to review this? |
Collaborator
|
Hi Curtis,
yes, I’ll review the code this week!
Cheers,
Radek
…Sent from my iPhone
On 9 Sep 2019, at 21:55, Curtis Rueden ***@***.***> wrote:
@rejsmont Do you have time to review this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
rejsmont
reviewed
Sep 19, 2019
| } while (tryAgain); | ||
|
|
||
|
|
||
| if (arg != null && arg.endsWith("hdf")){ |
Collaborator
There was a problem hiding this comment.
Hi @lukebfunk,
.hdf is not the only valid extension for hdf5 files. The other options and .h5and .hdf5. Please update your code to reflect this.
Collaborator
|
Also, this seems to be simple to make unit tests for. I would greatly appreciate if you had some time to do that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before opening a file selection dialog window, checks if plugin has been called with a valid file path string. This is very useful if you want to enable drag-and-drop file opening (without the dialog popping up every time) by setting relevant file types to open with HDF5_Reader_Vibez in HandleExtraFileTypes.java within FIJI's IO package.