Conversation
mbg
left a comment
mbg
left a comment
There was a problem hiding this comment.
@tathougies thanks for making this work with aeson 2! I noticed a few things related to the .cabal file that might need to be fixed before this can be merged.
@fieldstrength I like this library a lot and it would be nice to see it support aeson 2. Any chance this PR could get merged (with any necessary changes) and a new version could be pushed to Hackage then?
aeson-deriving.cabal
Outdated
| hs-source-dirs: | ||
| src | ||
| default-extensions: ConstraintKinds DataKinds DeriveFunctor DeriveGeneric DerivingStrategies FlexibleContexts FlexibleInstances GeneralizedNewtypeDeriving KindSignatures LambdaCase MultiParamTypeClasses NamedFieldPuns OverloadedStrings ScopedTypeVariables TupleSections TypeApplications TypeOperators | ||
| default-extensions: ConstraintKinds DataKinds DeriveFunctor DeriveGeneric DerivingStrategies FlexibleContexts FlexibleInstances GeneralizedNewtypeDeriving KindSignatures LambdaCase MultiParamTypeClasses NamedFieldPuns OverloadedStrings ScopedTypeVariables TupleSections TypeApplications TypeOperators CPP |
There was a problem hiding this comment.
I don't see CPP being used anywhere in the code changes -- is it leftover from some previous work / can it be removed?
aeson-deriving.cabal
Outdated
| ghc-options: -Wall -Wredundant-constraints -Wincomplete-record-updates -Wincomplete-uni-patterns | ||
| build-depends: | ||
| aeson >=1.2 && <1.6 | ||
| aeson >=1.2 && <2.1 |
There was a problem hiding this comment.
Should the lower bound also be 2.0 here? It is for the library component.
aeson-deriving.cabal
Outdated
| @@ -7,7 +7,7 @@ cabal-version: 1.12 | |||
| -- hash: 05a421de32621a1d52633e1311198dbc32abe2ea1f27c1e0f003d14a579b97e5 | |||
There was a problem hiding this comment.
The .cabal file is generated from package.yaml, but you seem to have edited the .cabal file directly. You should make the changes to package.yaml and then re-generate the .cabal file from it with hpack.
|
Is it stale? Is there any chance that this pull request will be merged? |
|
There is https://github.com/fumieval/deriving-aeson which seems to be similar to this library and is more actively maintained. |
3 participants
What the title says.