This repository was archived by the owner on Dec 10, 2024. It is now read-only.
Increased isoDep timeout for long transceive ops.#75
Open
Increased isoDep timeout for long transceive ops.#75
Conversation
Franzaine
reviewed
Nov 7, 2018
Member
Franzaine
left a comment
There was a problem hiding this comment.
Just as a question, since it hasn’t been extensively tested (to my knowledge), why are we not just setting the timeout with the setTimeout method?
Author
|
@Franzaine It is not related I think. We're increasing the default timeout to permit long operations by default. I think it is tested enough. About the use of |
e828b51 to
7ae678c
Compare
pepegar
approved these changes
Nov 8, 2018
7ae678c to
58044e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.