Skip to content
This repository was archived by the owner on Dec 10, 2024. It is now read-only.

Increased isoDep timeout for long transceive ops.#75

Open
monday8am wants to merge 2 commits intomasterfrom
increase-timeout
Open

Increased isoDep timeout for long transceive ops.#75
monday8am wants to merge 2 commits intomasterfrom
increase-timeout

Conversation

@monday8am
Copy link

No description provided.

@monday8am monday8am requested a review from Franzaine November 7, 2018 12:59
Copy link
Member

@Franzaine Franzaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a question, since it hasn’t been extensively tested (to my knowledge), why are we not just setting the timeout with the setTimeout method?

public void setTimeout(int timeout) {

@monday8am
Copy link
Author

@Franzaine It is not related I think. We're increasing the default timeout to permit long operations by default.
https://developer.android.com/reference/android/nfc/tech/IsoDep.html#setTimeout(int)

I think it is tested enough. About the use of setTimeOut, IMO is better to think it will work although we forget to call the method to set the correct time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants