This allows you to manage symbol keys#3
Open
binford2k wants to merge 1 commit intofiddyspence:masterfrom
Open
Conversation
Given a hash like
```puppet
$symbols = {
":bar" => {
"baz" => "foo",
"moo" => 1,
":cow" => "1",
}
}
```
Prior to this commit, this type would manage a hash with literal keys
with the colon in them and it was impossible to manage a hash with
symbolic keys. This commit will convert a string like `":thing"` to a
symbol, like `:thing` when managing yaml files.
Fixes fiddyspence#2
Owner
|
Hi de hi. I thunk each_with_object was a new in ruby 1.9.3 thing which would break all the EL6 (non puppet-agent users. I (deliberately because holiday) don't have access to a real computering device until early June to check properly sadly. Also it looks like Chris of the past was in a hurry (read lazy) and never bothered putting even the most basic of basic unit tests on the code (again I can fix this in June trivially). |
Contributor
Author
|
I do think you're right. I may push an update. In the meantime my bleeding ◔_◔ template will do. Have an awesome holiday! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given a hash like
Prior to this commit, this type would manage a hash with literal keys
with the colon in them and it was impossible to manage a hash with
symbolic keys. This commit will convert a string like
":thing"to asymbol, like
:thingwhen managing yaml files.Fixes #2