Add web UI for creating data and editing exercise types#249
Open
Add web UI for creating data and editing exercise types#249
Conversation
- Add new "Add Data" page with forms for activities, tags, and metrics - Add custom metrics management (CRUD) to Settings page - Show exercise type in exercise detail view (read + edit mode) - Add exercise_type support to updateActivity API (api-spec, backend, MCP) - Add API functions: addActivity, addTag, addMetric, addCustomMetric, updateCustomMetric, deleteCustomMetric - Add "+ Add" navigation link in header Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
Replace inline type definitions with proper imports from @aurboda/api-spec: - updateActivity: use UpdateActivityBody - addTag: use AddTagBody - addCustomMetric: use AddCustomMetricBody - updateCustomMetric: use UpdateCustomMetricBody Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
Mutations unit tests (5 tests): - Data merging with existing activity data - Preserving existing fields when adding new data - Setting data on activity with no existing data - Not passing data when input has no data field - Updating data and other fields together MCP tool tests (5 tests): - update_activity with exercise_type conversion - update_activity without exercise_type - Invalid exercise_type error handling - Time updates passed as Date objects - Service failure error propagation DB integration tests (4 tests): - updateActivity persists data field - Data field replacement at DB level - Preserving data when updating other fields - Updating data and other fields together Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #249 +/- ##
===========================================
- Coverage 27.31% 26.70% -0.62%
===========================================
Files 176 178 +2
Lines 23863 24536 +673
Branches 2134 2149 +15
===========================================
+ Hits 6519 6553 +34
- Misses 17305 17942 +637
- Partials 39 41 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/add): New page with tabbed forms for creating activities, tags, and metrics directly from the web UIexercise_typeto the update activity API (REST + MCP) with proper validation and data mergingTest plan
/addand verify all three tabs (Activity, Tag, Metric) work🤖 Generated with Claude Code