Skip to content

Comments

Fix point tag overlap in day view#246

Merged
fiddur merged 1 commit intodevelopfrom
fix/day-view-point-tag-overlap
Feb 23, 2026
Merged

Fix point tag overlap in day view#246
fiddur merged 1 commit intodevelopfrom
fix/day-view-point-tag-overlap

Conversation

@fiddur
Copy link
Owner

@fiddur fiddur commented Feb 23, 2026

Summary

  • Point tag text overflow: Left-align diamond markers within their lane so text labels stay bounded within lane width instead of overflowing into neighboring lanes
  • Lane assignment loss: Preserve original lane assignments in mergeSmallItems for non-merged items — previously all items were reset to lane: 0 when any tiny item triggered merging, causing overlapping items to render on top of each other

Test plan

  • Open day view with two point tags at the same time → they should display side by side in separate lanes
  • Open day view with a span tag and overlapping point tag → point tag text should not overflow into the span tag's lane
  • Verify merged cluster behavior still works for many tiny items close together

🤖 Generated with Claude Code

Two rendering bugs caused point tags to visually collide:

1. Point tag text overflowed lane boundaries because the diamond was
   centered in the lane but text width calculation assumed full lane
   width. Left-align the diamond within the lane so text stays bounded.

2. mergeSmallItems discarded lane assignments for ALL items (setting
   lane: 0) when any item in a column was tiny. Preserve original lane
   assignments for non-merged items so overlapping items render in
   separate lanes as intended.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.26%. Comparing base (5a39340) to head (f6524b0).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
apps/web/src/pages/DayView/index.tsx 0.00% 28 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #246   +/-   ##
========================================
  Coverage    27.26%   27.26%           
========================================
  Files          176      176           
  Lines        23752    23751    -1     
  Branches      2122     2122           
========================================
  Hits          6476     6476           
+ Misses       17237    17236    -1     
  Partials        39       39           
Flag Coverage Δ
android 8.57% <ø> (ø)
backend 57.58% <ø> (ø)
web 3.02% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fiddur fiddur merged commit 01d66a5 into develop Feb 23, 2026
3 of 4 checks passed
@fiddur fiddur deleted the fix/day-view-point-tag-overlap branch February 23, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant