Skip to content

Add partial Health Connect permissions + DB migration retry #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fiddur merged 1 commit into from
Feb 22, 2026
Merged

Add partial Health Connect permissions + DB migration retry #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 132 additions & 0 deletions apps/android/app/src/main/java/net/aurboda/HealthConnectPermissions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,132 @@
package net.aurboda

import androidx.health.connect.client.permission.HealthPermission
import androidx.health.connect.client.records.*
import kotlin.reflect.KClass

/**
* A user-friendly grouping of Health Connect record types into categories.
*/
data class HealthDataCategory(
val name: String,
val recordTypes: List<KClass<out Record>>,
val description: String
)

/**
* Permission status for a single category.
*/
data class CategoryPermissionStatus(
val category: HealthDataCategory,
val grantedCount: Int,
val totalCount: Int
) {
val allGranted: Boolean get() = grantedCount == totalCount
val noneGranted: Boolean get() = grantedCount == 0
val partiallyGranted: Boolean get() = grantedCount in 1 until totalCount
}

val healthDataCategories: List<HealthDataCategory> = listOf(
HealthDataCategory(
name = "Activity & Exercise",
recordTypes = listOf(
StepsRecord::class,
DistanceRecord::class,
ActiveCaloriesBurnedRecord::class,
TotalCaloriesBurnedRecord::class,
ExerciseSessionRecord::class,
SpeedRecord::class,
PowerRecord::class,
FloorsClimbedRecord::class,
CyclingPedalingCadenceRecord::class,
ElevationGainedRecord::class,
Vo2MaxRecord::class,
WheelchairPushesRecord::class
),
description = "Steps, distance, calories, exercise sessions, and more"
),
HealthDataCategory(
name = "Heart & Vitals",
recordTypes = listOf(
HeartRateRecord::class,
HeartRateVariabilityRmssdRecord::class,
RestingHeartRateRecord::class,
BloodPressureRecord::class,
OxygenSaturationRecord::class,
RespiratoryRateRecord::class,
BloodGlucoseRecord::class,
BasalMetabolicRateRecord::class
),
description = "Heart rate, HRV, blood pressure, SpO2, and more"
),
HealthDataCategory(
name = "Body Measurements",
recordTypes = listOf(
WeightRecord::class,
HeightRecord::class,
BodyFatRecord::class,
LeanBodyMassRecord::class,
BoneMassRecord::class,
BodyWaterMassRecord::class,
BodyTemperatureRecord::class,
BasalBodyTemperatureRecord::class
),
description = "Weight, height, body composition, and temperature"
),
HealthDataCategory(
name = "Sleep",
recordTypes = listOf(
SleepSessionRecord::class
),
description = "Sleep sessions and stages"
),
HealthDataCategory(
name = "Nutrition & Hydration",
recordTypes = listOf(
NutritionRecord::class,
HydrationRecord::class
),
description = "Food intake and hydration"
),
HealthDataCategory(
name = "Reproductive Health",
recordTypes = listOf(
CervicalMucusRecord::class,
IntermenstrualBleedingRecord::class,
MenstruationFlowRecord::class,
MenstruationPeriodRecord::class,
OvulationTestRecord::class,
SexualActivityRecord::class
),
description = "Menstrual cycle, ovulation, and related data"
)
)

/**
* Filter allRecordTypes to only those with a granted read permission.
*/
fun getGrantedRecordTypes(
grantedPermissions: Set<String>,
recordTypes: List<KClass<out Record>> = allRecordTypes
): List<KClass<out Record>> =
recordTypes.filter { recordType ->
HealthPermission.getReadPermission(recordType) in grantedPermissions
}

/**
* Compute per-category permission status from the set of granted permissions.
*/
fun getCategoryStatuses(
grantedPermissions: Set<String>,
categories: List<HealthDataCategory> = healthDataCategories
): List<CategoryPermissionStatus> =
categories.map { category ->
val grantedCount = category.recordTypes.count { recordType ->
HealthPermission.getReadPermission(recordType) in grantedPermissions
}
CategoryPermissionStatus(
category = category,
grantedCount = grantedCount,
totalCount = category.recordTypes.size
)
}
72 changes: 55 additions & 17 deletions apps/android/app/src/main/java/net/aurboda/HealthConnectSyncWorker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import androidx.health.connect.client.HealthConnectClient
import androidx.health.connect.client.aggregate.AggregateMetric
import androidx.health.connect.client.changes.DeletionChange
import androidx.health.connect.client.changes.UpsertionChange
import androidx.health.connect.client.permission.HealthPermission
import androidx.health.connect.client.records.*
import androidx.health.connect.client.request.AggregateRequest
import androidx.health.connect.client.request.ChangesTokenRequest
Expand All @@ -26,7 +25,6 @@ import io.ktor.client.plugins.contentnegotiation.ContentNegotiation
import io.ktor.client.request.headers
import io.ktor.client.request.post
import io.ktor.client.request.setBody
import io.ktor.client.statement.bodyAsText
import io.ktor.http.ContentType
import io.ktor.http.HttpHeaders
import io.ktor.http.HttpStatusCode
Expand All @@ -37,10 +35,12 @@ import net.aurboda.api.models.DailyAggregate
import net.aurboda.api.models.DailyAggregatesBody
import net.aurboda.widget.HrZoneWidgetProvider
import java.util.concurrent.TimeUnit
import kotlin.reflect.KClass

private const val TAG = "HealthConnectSyncWorker"
private const val PREFS_NAME = "AurbodaAppPrefs"
private const val CHANGES_TOKEN_KEY = "healthConnectChangesToken"
private const val GRANTED_TYPES_KEY = "grantedRecordTypeNames"
private const val WORK_NAME = "health_connect_sync"

class HealthConnectSyncWorker(
Expand All @@ -55,13 +55,19 @@ class HealthConnectSyncWorker(
}
}

// Cumulative metrics that should be aggregated to avoid duplication
private val aggregatableMetrics: List<Pair<AggregateMetric<*>, DailyAggregate.Metric>> = listOf(
Pair(StepsRecord.COUNT_TOTAL, DailyAggregate.Metric.steps),
Pair(DistanceRecord.DISTANCE_TOTAL, DailyAggregate.Metric.distance),
Pair(ActiveCaloriesBurnedRecord.ACTIVE_CALORIES_TOTAL, DailyAggregate.Metric.calories_active),
Pair(TotalCaloriesBurnedRecord.ENERGY_TOTAL, DailyAggregate.Metric.calories_total),
Pair(FloorsClimbedRecord.FLOORS_CLIMBED_TOTAL, DailyAggregate.Metric.floors_climbed)
// Cumulative metrics with the record class they require permission for
private data class AggregatableMetric(
val aggregateMetric: AggregateMetric<*>,
val dailyMetric: DailyAggregate.Metric,
val recordClass: KClass<out Record>
)

private val allAggregatableMetrics: List<AggregatableMetric> = listOf(
AggregatableMetric(StepsRecord.COUNT_TOTAL, DailyAggregate.Metric.steps, StepsRecord::class),
AggregatableMetric(DistanceRecord.DISTANCE_TOTAL, DailyAggregate.Metric.distance, DistanceRecord::class),
AggregatableMetric(ActiveCaloriesBurnedRecord.ACTIVE_CALORIES_TOTAL, DailyAggregate.Metric.calories_active, ActiveCaloriesBurnedRecord::class),
AggregatableMetric(TotalCaloriesBurnedRecord.ENERGY_TOTAL, DailyAggregate.Metric.calories_total, TotalCaloriesBurnedRecord::class),
AggregatableMetric(FloorsClimbedRecord.FLOORS_CLIMBED_TOTAL, DailyAggregate.Metric.floors_climbed, FloorsClimbedRecord::class)
)

override suspend fun doWork(): Result {
Expand All @@ -73,17 +79,25 @@ class HealthConnectSyncWorker(
return Result.success()
}

// Check permissions
val permissions = allRecordTypes.map { HealthPermission.getReadPermission(it) }.toSet()
// Check permissions — proceed with whatever is granted (partial permissions support)
val grantedPermissions = healthConnectClient.permissionController.getGrantedPermissions()
if (!grantedPermissions.containsAll(permissions)) {
Log.w(TAG, "Not all permissions granted, skipping sync")
val grantedTypes = getGrantedRecordTypes(grantedPermissions)
if (grantedTypes.isEmpty()) {
Log.w(TAG, "No permissions granted, skipping sync")
return Result.success()
}
Log.d(TAG, "Granted ${grantedTypes.size}/${allRecordTypes.size} record types")

// Invalidate token if granted types changed since last sync
invalidateTokenIfGrantedTypesChanged(grantedTypes)

// Filter aggregatable metrics to only those with granted permissions
val grantedTypeSet = grantedTypes.toSet()
val activeAggregateMetrics = allAggregatableMetrics.filter { it.recordClass in grantedTypeSet }

return try {
// Step 1: Fetch and send daily aggregates for cumulative metrics (deduplicated)
val aggregates = fetchDailyAggregates(days = 7)
val aggregates = fetchDailyAggregates(activeAggregateMetrics, days = 7)
if (aggregates.isNotEmpty()) {
val aggregateSuccess = sendDailyAggregates(aggregates, credentials.apiUrl, credentials.authToken)
if (!aggregateSuccess) {
Expand Down Expand Up @@ -381,11 +395,35 @@ class HealthConnectSyncWorker(
return prefs.getString(CHANGES_TOKEN_KEY, null)
}

/**
* Check if granted types changed and invalidate the changes token if so.
*/
private fun invalidateTokenIfGrantedTypesChanged(currentGrantedTypes: List<KClass<out Record>>) {
val prefs = applicationContext.getSharedPreferences(PREFS_NAME, Context.MODE_PRIVATE)
val currentNames = currentGrantedTypes.map { it.simpleName ?: "" }.sorted().joinToString(",")
val savedNames = prefs.getString(GRANTED_TYPES_KEY, null)

if (savedNames != null && savedNames != currentNames) {
Log.d(TAG, "Granted types changed, invalidating changes token")
prefs.edit()
.remove(CHANGES_TOKEN_KEY)
.putString(GRANTED_TYPES_KEY, currentNames)
.apply()
} else {
prefs.edit().putString(GRANTED_TYPES_KEY, currentNames).apply()
}
}

/**
* Fetch daily aggregates for cumulative metrics using Health Connect's aggregate() API.
* This automatically deduplicates based on user-configured app priority.
* Only fetches for metrics that have granted permissions.
*/
private suspend fun fetchDailyAggregates(days: Int = 7): List<DailyAggregate> {
private suspend fun fetchDailyAggregates(
metrics: List<AggregatableMetric>,
days: Int = 7
): List<DailyAggregate> {
if (metrics.isEmpty()) return emptyList()

val aggregates = mutableListOf<DailyAggregate>()
val today = LocalDate.now()
val zoneId = ZoneId.systemDefault()
Expand All @@ -395,7 +433,7 @@ class HealthConnectSyncWorker(
val startTime = date.atStartOfDay(zoneId).toInstant()
val endTime = date.plusDays(1).atStartOfDay(zoneId).toInstant()

for ((metric, metricType) in aggregatableMetrics) {
for ((metric, metricType, _) in metrics) {
try {
val request = AggregateRequest(
metrics = setOf(metric),
Expand Down
Loading
Loading