Fix: Crash on showing too many elements#4
Merged
fidarit merged 4 commits intofidarit:masterfrom Nov 18, 2025
Merged
Conversation
this is necessary because 'recycleElement(e, i + FirstIndex)' does modify the the elements
Owner
Author
|
I'm trying to reproduce the issue locally and will add a few tests to cover this case before merging |
Owner
Author
|
Couldn't reproduce locally, but it's a tiny zero-overhead guard that prevents a possible IndexOutOfRange during recycling and literally can't hurt anything.. merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from AvaloniaUI#314 by @manuelmainz