Skip to content

Conversation

@AndreaEste97
Copy link

The following has been added:

  • two functions (calculate_velocity_of_corrosion and calculate_minimum_area_after_corrosion), which implements many formula of ModelCode2020 (chapter 30.1). These functions are located in a new file, corrosion.py, which is placed in a new folder (structuralcodes.development), along with a blank init.py file.

  • an example code usage_corrosion, which is located near the other example codes in docs._example_code.

  • many of these two functions, which are placed in a new file, test_corrosion.py, which is located in a new folder, test_corrosion, which is located near the other test folders in tests.

@AndreaEste97 AndreaEste97 marked this pull request as draft December 10, 2025 15:43
@AndreaEste97 AndreaEste97 marked this pull request as ready for review December 10, 2025 15:47
@AndreaEste97 AndreaEste97 reopened this Dec 10, 2025
@mortenengen mortenengen added the MC2020 fib Model Code 2020 label Dec 12, 2025
@mortenengen mortenengen moved this to Needs review 📣 in PR tracker Dec 12, 2025
@talledodiego talledodiego changed the title Added corrosion functions. Added corrosion functions Dec 12, 2025
@talledodiego talledodiego changed the base branch from main to dev December 12, 2025 11:26
@github-project-automation github-project-automation bot moved this from Needs review 📣 to Under review 👀 in PR tracker Dec 15, 2025
@AndreaEste97 AndreaEste97 reopened this Dec 15, 2025
@AndreaEste97
Copy link
Author

The following changes have been applied:

  • t.Optional has been changed to t.Literal
    --> now VScode suggestions are available
  • _corrosion.py file has been moved to mc2020 folder, removing the newly added development folder.
  • _use_design_code has been removed from the new functions
    --> now the functions does not raise errore even if no design code is specified.
  • tests have been updated to match the previous changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MC2020 fib Model Code 2020

Projects

Status: Under review 👀

Development

Successfully merging this pull request may close these issues.

2 participants