Skip to content

feat: add ElasticPlastic2D material class with tests #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
saraschei wants to merge 11 commits into
base: implement-shell-section
Choose a base branch
from
Open

feat: add ElasticPlastic2D material class with tests #243

saraschei wants to merge 11 commits into from

Conversation

@saraschei
Copy link

@saraschei saraschei commented May 7, 2025

No description provided.

@saraschei saraschei changed the title feat: add ElasticElastic2D material class with tests feat: add ElasticPlastic2D material class with tests May 7, 2025
@mortenengen mortenengen moved this to New ✨ in PR tracker May 12, 2025
@mortenengen mortenengen added the sections Development of sections label May 12, 2025
@saraschei saraschei marked this pull request as ready for review May 12, 2025 07:06
mortenengen
mortenengen reviewed May 12, 2025
View reviewed changes
mortenengen
mortenengen reviewed May 13, 2025
View reviewed changes
structuralcodes/materials/constitutive_laws/__init__.py
from ._elasticplastic import ElasticPlastic
from ._elasticplastic_2d import ElasticPlastic2D
from ._parabolarectangle import ParabolaRectangle
from ._parabolarectangle_2d import ParabolaRectangle2D
Copy link
Member

@mortenengen mortenengen May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the tests are failing because we are trying to import ParabolaRectangle2D, but this is not available, since it is being implemented in #242. Please remove this for now, and we will make sure it exists after merging #242.

Copy link
Author

@saraschei saraschei May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in commit 3362924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mortenengen mortenengen mortenengen left review comments

Assignees

No one assigned

Labels

sections Development of sections

Projects

PR tracker
Status: New ✨

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saraschei @mortenengen