feat: EC2 2023 8.6-Partially Loaded Areas #125
Conversation
Co-authored-by: talledodiego <38036285+talledodiego@users.noreply.github.com>
…codes into ec_2004_crack_control
mortenengen
left a comment
mortenengen
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I have merged dev and provided a minor fix to the docstring.
There are some lines that are not covered by tests. Please add tests so that we reach 100% coverage on the added lines.
talledodiego
left a comment
talledodiego
left a comment
There was a problem hiding this comment.
Perfect. Just a couple of minor comments.
| wk_cal, | ||
| wk_cal2, | ||
| ) | ||
| from ._section_8_6_partially_loaded_areas import sigma_Rd_u |
There was a problem hiding this comment.
maybe it is better the name sigma_Rdu? The u is not a subscript of Rd
| """Calculate the design resistance for partially loaded areas without | ||
| horizontal force components. | ||
|
|
||
| EN1992-1-1:2023 Eq. (8.126). |
There was a problem hiding this comment.
Actually here there is not only (8.126) implemented, but also (8.127), (8.128), (8.129),...
A 1:1 implementation of (8.126) would require as input arguments in the function signature: fcd, Ac1, Ac0, nu_part
| # Eccentrically reduced loaded area | ||
| a0_red = a0 - 2 * ea | ||
| b0_red = b0 - 2 * eb | ||
| Ac0_red = a0_red * b0_red # in mm² |
There was a problem hiding this comment.
Continuing above comment, for instance if we are in concentrically loaded area with don't need eccentiricity and determination of Ac0,red, so I find it strange having to specify this as a mandatory input.
One possible solution is refactor these equations into multiple functions. Alternatively we could use default values documenting it?
What do you think?
talledodiego
moved this from Compliance review
to Changes requested
in EC2 2023 PR tracker
3 participants
Small code for Chapter 8.6 from the new Eurocode 2:2023.