feat: EC2 2023 8.3-Torsion #122
Conversation
Co-authored-by: talledodiego <38036285+talledodiego@users.noreply.github.com>
…codes into ec_2004_crack_control
mortenengen
left a comment
mortenengen
left a comment
There was a problem hiding this comment.
Thanks for the good contribution 👍
I have merged dev and provided some minor fixes to the docstrings.
There are however a couple of lines that are not covered by tests. Please add tests so that we reach 100 % coverage for the added lines.
talledodiego
left a comment
talledodiego
left a comment
There was a problem hiding this comment.
Great!
Just a couple of minor comments.
| s (float): Spacing between the shear reinforcement in mm. | ||
| theta (float): Cotangent of the angle of compression field with respect | ||
| to the longitudinal axis. | ||
| cot_theta_min (float): Limit value for the cotangent. |
There was a problem hiding this comment.
add "defined in 8.2.3(4)"?
| Asl: List[float], | ||
| fyd: List[float], |
There was a problem hiding this comment.
Should we support only a plain a list or anything that is array-like? I am good with both, I am just thinking about similar implementations in otherparts of the code. Probably we should seek some uniformity?
| n = len(Asl) | ||
| for i in range(n): | ||
| sum_r += Asl[i] * fyd[i] |
There was a problem hiding this comment.
I find it more pythonic (but maybe it is simply my preference):
for a, f in zip(Asl, fyd):
sum_r += a * f
| EN1992-1-1:2023 Eq. (8.84), (8.85). | ||
|
|
||
| Args: | ||
| nu (float): Coefficient as determined by the formulae in Annex G. |
There was a problem hiding this comment.
Add: 'a value of nu = 0.6 may be used when cot_theta = 1.0'?
|
|
||
| Args: | ||
| tau_t_rd_sw (float): Torsional capacity governed by yielding of the | ||
| shear reinforcement in MPa. |
There was a problem hiding this comment.
add "computed by eq. (8.82)"?
| tau_t_rd_sw (float): Torsional capacity governed by yielding of the | ||
| shear reinforcement in MPa. | ||
| tau_t_rd_sl (float): Torsional capacity governed by yielding of the | ||
| longitudinal reinforcement in MPa. |
There was a problem hiding this comment.
add "computed by eq. (8.83)"?
| tau_t_rd_sl (float): Torsional capacity governed by yielding of the | ||
| longitudinal reinforcement in MPa. | ||
| tau_t_rd_max (float): Torsional capacity governed by crushing of the | ||
| compression field in concrete in MPa. |
There was a problem hiding this comment.
add "computed by eq. (8.84)"?
talledodiego
moved this from Compliance review
to Changes requested
in EC2 2023 PR tracker
3 participants
Here is my implementation of the Chapter 8.3-Torsion from the new Eurocode 2:2023.