Remove support for Qt<=5.0.0#60
Merged
jfmcarreira merged 1 commit intofhackenberger:masterfrom Mar 9, 2024
Merged
Conversation
Collaborator
|
Thank you for your contribution. I have been away from Linux and not using much this tool anymore that why the dated code. |
Merged
|
Given Qt5 is no longer maintained, and the last release of ktikz is four years old, we should make progress with the transition to Qt6 and more modern CMake. If you are interested, I am happy to help were I can. First step, can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was hoping to slowly get qtikz / ktikz ported to Qt6 / KF6. This is a first small piece of that that does some code cleanup and removes some old ifdefs.
I'm planning on mostly making everything compile on Qt 5.15 without any deprecation warnings and then seeing about porting to Qt6 / KF6. What do you think? Is #58 still a ongoing?