Skip to content

enhancement/fix : function _canShowPopup - check if can show popup... #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
demonslord wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enhancement/fix : function _canShowPopup - check if can show popup... #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions jquery.ui.timepicker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@
$(button).bind("click.timepicker", function () {
if ($.timepicker._timepickerShowing && $.timepicker._lastInput == input[0]) {
$.timepicker._hideTimepicker();
} else if (!inst.input.is(':disabled')) {
} else {
$.timepicker._showTimepicker(input[0]);
}
return false;
Expand Down Expand Up @@ -330,6 +330,11 @@
var inst = $.timepicker._getInst(input);
inst.tpDiv.css('zIndex', $.timepicker._getZIndex(input) +1);
},

/* Checks if can show popup */
_canShowPopup: function(element) {
return ( (!element.readOnly) && (!element.disabled) && (!$.timepicker._isDisabledTimepicker(element)) && ($.timepicker._lastInput != element) );
},

/* Pop-up the time picker for a given input field.
@param input element - the input field attached to the time picker or
Expand All @@ -338,7 +343,7 @@
input = input.target || input;
if (input.nodeName.toLowerCase() != 'input') { input = $('input', input.parentNode)[0]; } // find from button/image trigger

if ($.timepicker._isDisabledTimepicker(input) || $.timepicker._lastInput == input) { return; } // already here
if (!$.timepicker._canShowPopup(input)) { return; }

// fix v 0.0.8 - close current timepicker before showing another one
$.timepicker._hideTimepicker();
Expand Down