fix: parse checkpoint and localcheckpoint rule lines#53
Conversation
Snakemake logs checkpoint rules as "checkpoint X:" or "localcheckpoint X:" instead of "rule X:" or "localrule X:". RULE_START_PATTERN only matched the rule/localrule forms, making checkpoint jobs invisible to all log-based parsers. This caused checkpoint timing to be either lost or misattributed to whichever rule preceded the checkpoint in the log. Update RULE_START_PATTERN to match all four forms and add checkpoint prefixes to the LogLineParser fast-path checks. Closes #43
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe parser now recognizes checkpoint rules ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 88.25% 88.47% +0.21%
==========================================
Files 48 48
Lines 4692 4684 -8
==========================================
+ Hits 4141 4144 +3
+ Misses 551 540 -11
🚀 New features to boost your workflow:
|
Summary
checkpoint X:/localcheckpoint X:instead ofrule X:/localrule X:RULE_START_PATTERNonly matched rule/localrule, making checkpoint jobs invisible to all log-based parsers — timing was lost or misattributed to whatever rule preceded the checkpoint in the log(?:local)?(?:rule|checkpoint) (\w+):and add checkpoint prefixes to LogLineParser fast-path checksTest plan
Closes #43
Summary by CodeRabbit
New Features
Tests