doc: update fulcrum genomics logo with light/dark theme support#10
doc: update fulcrum genomics logo with light/dark theme support#10
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughReplaced the README logo Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Around line 23-24: The badge image tags lack alt attributes (violates MD045);
update the two <img> elements
(src="https://img.shields.io/badge/Email_us-%2338b44a.svg?&style=for-the-badge&logo=gmail&logoColor=white"
and
src="https://img.shields.io/badge/Visit_Us-%2326a8e0.svg?&style=for-the-badge&logo=wordpress&logoColor=white")
to include meaningful alt text (e.g., alt="Email Fulcrum Genomics" and
alt="Visit Fulcrum Genomics website") so screen readers can describe the badges
and the markdown linter MD045 is satisfied.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 16266224-74e3-4b0b-900e-8cac56661484
⛔ Files ignored due to path filters (2)
.github/logos/fulcrumgenomics-dark.svgis excluded by!**/*.svg.github/logos/fulcrumgenomics-light.svgis excluded by!**/*.svg
📒 Files selected for processing (1)
README.md
| <a href="mailto:contact@fulcrumgenomics.com?subject=[GitHub inquiry]"><img src="https://img.shields.io/badge/Email_us-%2338b44a.svg?&style=for-the-badge&logo=gmail&logoColor=white"/></a> | ||
| <a href="https://www.fulcrumgenomics.com"><img src="https://img.shields.io/badge/Visit_Us-%2326a8e0.svg?&style=for-the-badge&logo=wordpress&logoColor=white"/></a> |
There was a problem hiding this comment.
Add alt text to badge images for accessibility.
The badge images are missing alt attributes, which prevents screen readers from describing them to users with visual impairments. As per static analysis hints, this violates markdown linting rule MD045.
♿ Proposed fix to add alt text
-<a href="mailto:contact@fulcrumgenomics.com?subject=[GitHub inquiry]"><img src="https://img.shields.io/badge/Email_us-%2338b44a.svg?&style=for-the-badge&logo=gmail&logoColor=white"/></a>
-<a href="https://www.fulcrumgenomics.com"><img src="https://img.shields.io/badge/Visit_Us-%2326a8e0.svg?&style=for-the-badge&logo=wordpress&logoColor=white"/></a>
+<a href="mailto:contact@fulcrumgenomics.com?subject=[GitHub inquiry]"><img alt="Email us" src="https://img.shields.io/badge/Email_us-%2338b44a.svg?&style=for-the-badge&logo=gmail&logoColor=white"/></a>
+<a href="https://www.fulcrumgenomics.com"><img alt="Visit us" src="https://img.shields.io/badge/Visit_Us-%2326a8e0.svg?&style=for-the-badge&logo=wordpress&logoColor=white"/></a>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <a href="mailto:contact@fulcrumgenomics.com?subject=[GitHub inquiry]"><img src="https://img.shields.io/badge/Email_us-%2338b44a.svg?&style=for-the-badge&logo=gmail&logoColor=white"/></a> | |
| <a href="https://www.fulcrumgenomics.com"><img src="https://img.shields.io/badge/Visit_Us-%2326a8e0.svg?&style=for-the-badge&logo=wordpress&logoColor=white"/></a> | |
| <a href="mailto:contact@fulcrumgenomics.com?subject=[GitHub inquiry]"><img alt="Email us" src="https://img.shields.io/badge/Email_us-%2338b44a.svg?&style=for-the-badge&logo=gmail&logoColor=white"/></a> | |
| <a href="https://www.fulcrumgenomics.com"><img alt="Visit us" src="https://img.shields.io/badge/Visit_Us-%2326a8e0.svg?&style=for-the-badge&logo=wordpress&logoColor=white"/></a> |
🧰 Tools
🪛 markdownlint-cli2 (0.22.0)
[warning] 23-23: Images should have alternate text (alt text)
(MD045, no-alt-text)
[warning] 24-24: Images should have alternate text (alt text)
(MD045, no-alt-text)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` around lines 23 - 24, The badge image tags lack alt attributes
(violates MD045); update the two <img> elements
(src="https://img.shields.io/badge/Email_us-%2338b44a.svg?&style=for-the-badge&logo=gmail&logoColor=white"
and
src="https://img.shields.io/badge/Visit_Us-%2326a8e0.svg?&style=for-the-badge&logo=wordpress&logoColor=white")
to include meaningful alt text (e.g., alt="Email Fulcrum Genomics" and
alt="Visit Fulcrum Genomics website") so screen readers can describe the badges
and the markdown linter MD045 is satisfied.
The fg-labs org requires all actions to be pinned to full-length commit SHAs. Pin every remaining action reference and switch taiki-e/install-action to the v2 form with an explicit tool input.
Summary
Summary by CodeRabbit
Documentation
Chores