feat: add compute_haplotypes tool#8
Open
ameynert wants to merge 1 commit intoam_06_extract_gnomad_afsfrom
Open
feat: add compute_haplotypes tool#8ameynert wants to merge 1 commit intoam_06_extract_gnomad_afsfrom
ameynert wants to merge 1 commit intoam_06_extract_gnomad_afsfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
616578d to
c41aafa
Compare
Port compute_haplotypes.py from human-diversity-reference/scripts as a defopt-compatible toolkit tool. Reads VCF files, annotates variants with gnomAD population allele frequencies, and extracts phased haplotypes per population using two overlapping genomic windows, writing the union as a keyed Hail table. Extracts the inner get_haplotypes function to module-level _get_haplotypes and replaces typer.echo with logging. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
250c6ca to
b8eef18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compute_haplotypes.pyfromhuman-diversity-reference/scriptsas a defopt-compatible toolkit toolget_haplotypesfunction to module-level_get_haplotypesand replacestyper.echowith loggingTest plan
uv run --directory divref poe check-allpasses🤖 Generated with Claude Code