Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe project configuration was expanded to include new data processing dependencies (duckdb, hail, pandas, polars, pydantic, tqdm) in pyproject.toml, with corresponding MyPy configuration updates to handle missing type stubs. The pixi environment was updated to enable hail feature support with openjdk runtime requirement. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/workflow_linting.yml (1)
3-5: Consider running this lint workflow onpull_requestas well.
push-only triggers can miss PR-time feedback paths (especially fork PRs).Suggested trigger update
on: push: + pull_request:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/workflow_linting.yml around lines 3 - 5, The workflow currently only triggers on the push event (the on: push: block); update the trigger to include pull_request as well so the lint job runs on PRs (including fork PRs) — e.g., modify the on: block to list both push and pull_request events (or use on: [push, pull_request]) so the CI provides PR-time lint feedback.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CONTRIBUTING.md`:
- Around line 49-59: The two headings using "######" should be changed to the
correct hierarchical level to avoid an h6 jump: update the headings "For Running
Individual Toolkit Checks" and "For Running All Toolkit Checks" to match the
surrounding section level (e.g., change the leading "######" to "###" or the
appropriate number of '#' to follow the previous heading level), ensuring
consistent incremental heading levels throughout CONTRIBUTING.md.
In `@pixi.toml`:
- Around line 16-31: The workspace lock file pixi.lock is out of sync with the
updated manifest (pixi.toml) where features/environments/tasks were changed;
regenerate the lock and commit it: run the pixi lock command against the current
manifest state (e.g., run "pixi lock" or the project's prescribed lock
generation command), verify the lock updates include the new
feature.hail.dependencies/openjdk and environments.default entries, then add and
commit the updated pixi.lock so CI no longer fails with --locked installs.
---
Nitpick comments:
In @.github/workflows/workflow_linting.yml:
- Around line 3-5: The workflow currently only triggers on the push event (the
on: push: block); update the trigger to include pull_request as well so the lint
job runs on PRs (including fork PRs) — e.g., modify the on: block to list both
push and pull_request events (or use on: [push, pull_request]) so the CI
provides PR-time lint feedback.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1b26f066-efba-430a-ac47-4da7ad6b6564
⛔ Files ignored due to path filters (2)
divref/uv.lockis excluded by!**/*.lockpixi.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
.github/workflows/python_package.yml.github/workflows/workflow_linting.ymlCONTRIBUTING.mddivref/pyproject.tomlpixi.tomlworkflows/download.smk
Comment on lines
+16
to
+31
| [feature.hail.dependencies] | ||
| openjdk = ">=11" | ||
|
|
||
| [environments] | ||
| default = { features = ["snakemake"] } | ||
| default = { features = ["snakemake", "hail"] } | ||
|
|
||
| [tasks] | ||
| check-toolkit = "uv run --directory divref poe check-all" | ||
| fix-and-check-toolkit = "uv run --directory divref poe fix-and-check-all" | ||
|
|
||
| check-lock = "pixi lock --check" | ||
|
|
||
| check-all = [ | ||
| { task = "check-toolkit" }, | ||
| { task = "check-lock" }, | ||
| ] |
There was a problem hiding this comment.
pixi.lock is out of sync with the workspace manifest.
The pipeline failure indicates --locked installs are currently broken after these feature/environment changes. Please regenerate and commit an updated pixi.lock from this exact manifest state.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pixi.toml` around lines 16 - 31, The workspace lock file pixi.lock is out of
sync with the updated manifest (pixi.toml) where features/environments/tasks
were changed; regenerate the lock and commit it: run the pixi lock command
against the current manifest state (e.g., run "pixi lock" or the project's
prescribed lock generation command), verify the lock updates include the new
feature.hail.dependencies/openjdk and environments.default entries, then add and
commit the updated pixi.lock so CI no longer fails with --locked installs.
ameynert
temporarily deployed
to
github-actions-snakemake-linting
GitHub Actions
Inactive
Add hail, polars, duckdb, pandas, pydantic, and tqdm as Python dependencies in divref/pyproject.toml. Add mypy ignore_missing_imports overrides for hail and tqdm (no type stubs). Add openjdk>=11 as a conda dependency in a new pixi 'hail' feature and include it in the default environment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ameynert
temporarily deployed
to
github-actions-snakemake-linting
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hail,polars,duckdb,pandas,pydantic, andtqdmas Python dependencies indivref/pyproject.tomlmypyignore_missing_importsoverrides forhailandtqdm(no upstream type stubs available)openjdk>=11as a conda dependency via a newhailpixi feature, included in the default environmentuv.lockandpixi.lockto reflect the new dependenciesTest plan
pixi run fix-and-check-allpasses🤖 Generated with Claude Code
Summary by CodeRabbit