test: add tests for rewrite_fasta#17
Open
ameynert wants to merge 1 commit intoam_15_test_remap_divref_modelsfrom
Open
test: add tests for rewrite_fasta#17ameynert wants to merge 1 commit intoam_15_test_remap_divref_modelsfrom
ameynert wants to merge 1 commit intoam_15_test_remap_divref_modelsfrom
Conversation
Adds tests/tools/test_rewrite_fasta.py covering rewrite_fasta() using pytest's tmp_path fixture: - Canonical autosomes (chr1, chr22) are kept - Sex chromosomes (chrX, chrY) and chrMT are kept - Alt contigs (chr1_alt) and decoys (chrUn_gl000220, chrEBV) are filtered - Mixed input with canonical and non-canonical contigs interleaved - Empty input produces empty output - Multi-line sequences are written in full Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
tests/tools/test_rewrite_fasta.pycoveringrewrite_fasta()usingpytest'stmp_pathfixture. No Hail or external data required — all tests use in-memory FASTA strings written to temp files.Cases covered:
chr1–chr22are keptchrX,chrY, andchrMTare keptchr1_alt), unplaced contigs (chrUn_gl000220), and virus sequences (chrEBV) are filtered outTest plan
uv run --directory divref poe check-allpasses🤖 Generated with Claude Code