test: add unit tests for Variant, ReferenceMapping, Haplotype, and _parse_pop_freqs#16
Open
ameynert wants to merge 1 commit intoam_14_test_haplotypefrom
Open
test: add unit tests for Variant, ReferenceMapping, Haplotype, and _parse_pop_freqs#16ameynert wants to merge 1 commit intoam_14_test_haplotypefrom
ameynert wants to merge 1 commit intoam_14_test_haplotypefrom
Conversation
…arse_pop_freqs Extends test_remap_divref.py with direct tests for the model methods and private helper that were previously only exercised indirectly via reference_mapping(): - Variant.render(): SNP, insertion, deletion - Haplotype.parsed_variants(): single variant, multiple variants, caching (second call returns same list object) - Haplotype.contig(): returns chromosome of first variant - ReferenceMapping.variants_involved_str(): empty, single, multiple - _parse_pop_freqs(): all floats, mixed nulls, single null Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
tests/tools/test_remap_divref.pywith direct unit tests for methods and a private helper that were previously only exercised indirectly throughHaplotype.reference_mapping():Variant.render()— SNP, insertion, deletionHaplotype.parsed_variants()— single variant, multiple variants, caching (second call returns the same list object with no re-parsing)Haplotype.contig()— returns chromosome of first variantReferenceMapping.variants_involved_str()— empty list, single variant, multiple variants_parse_pop_freqs()— all floats, mixed nulls converted to 0.0, single nullNone of these require Hail; all are pure Python.
Test plan
uv run --directory divref poe check-allpasses🤖 Generated with Claude Code