feat: Meta Quest Browser fix for ace editor zoom issue#127
Open
TiborUdvari wants to merge 1 commit intoffd8:mainfrom
Open
feat: Meta Quest Browser fix for ace editor zoom issue#127TiborUdvari wants to merge 1 commit intoffd8:mainfrom
TiborUdvari wants to merge 1 commit intoffd8:mainfrom
Conversation
Owner
|
Nice idea – I'll have to test it out very soon on a Quest to see exactly what it's changing. Due to the size and singularly of the function etc – I'd rather it just get embedded directly within the monster index.html file, instead of external link. It can be called towards the end of settings rather than a listener on the |
Author
|
I did it like this because it modifies the ace editor css, since it's a hacky patch I though it would be best to only have it load when it's an Oculus Browser, that way it's 100% sure not to interfere with any other stuff Notice checking the user agent if (!navigator.userAgent.includes("OculusBrowser")){
return;
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #123.
I checked if it's the right browser, not to break anything for anyone else accidentally.