style: re-export leveldb_sys dep, used in our API#1
Open
dan-da wants to merge 1 commit intofetchadd:masterfrom
Open
style: re-export leveldb_sys dep, used in our API#1dan-da wants to merge 1 commit intofetchadd:masterfrom
dan-da wants to merge 1 commit intofetchadd:masterfrom
Conversation
leveldb_sys is publicly exposed in Options::compression, and possibly elsewhere. With this change, an rs-leveldb user can access leveldb::leveldb_sys::Compression or other leveldb_sys elements without requiring an explicit Cargo dep on leveldb_sys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
leveldb_sys is publicly exposed in Options::compression, and possibly elsewhere.
With this change, an rs-leveldb user can access
leveldb::leveldb_sys::Compression or other leveldb_sys elements without requiring an explicit Cargo dep on leveldb_sys.
note: I did not check if any other crates are exposed in the public API. That would be a worthwhile exercise, but this PR is useful as-is.