Skip to content

Conversation

@sthibaul
Copy link
Contributor

eade31a ("Honor environment variables passed at ./configure") made
speech_tools record build flags in user_flags.mak. This however make the
build less reproducible by recording flags from the environment. Also,
external applications using it do not actually need to get flags from
that, they can just inherit them from their own environment. Actually,
I'd even argue that this is preferrable over seeing speech_tools
hardcode flags that applications using its build system will then have
to use.

eade31a ("Honor environment variables passed at ./configure") made
speech_tools record build flags in user_flags.mak. This however make the
build less reproducible by recording flags from the environment. Also,
external applications using it do not actually need to get flags from
that, they can just inherit them from their own environment. Actually,
I'd even argue that this is preferrable over seeing speech_tools
hardcode flags that applications using its build system will then have
to use.
@lenzo-ka
Copy link
Collaborator

lenzo-ka commented Jan 6, 2021

I'm hoping to get to this shortly... I'd like to test and get a couple other things in first and make sure we don't have conflicts, but this is a good thing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants