Internalnodebuttons #188
Merged
Internalnodebuttons #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
RemDelaporteMathurin
left a comment
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
@SakkiWakki thanks for this! I see there are a few bugs indeed. For example, spawn two amplifiers, select one, click delete on the other: it deletes the first one.
Aside from that, this is the right functionality!
Collaborator
|
@SakkiWakki should we merge this then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, delete and duplicate buttons. They are buggy so I think I have to refactor App.jsx before making any major changes. This is because the delete and duplicate buttons currently work off the same functionality in App.jsx. For example, the node-internal delete button only functions if you first click the node and then click the delete button.
I think that if the delete and duplicate functionality is not consistent throughout the app, then there will be very scary bugs down the road.