Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves how the injector resolves/modifies the LuaJIT mod configuration by introducing a richer config resolution path (modinfo defaults → luajit_config.json → save/modoverrides → env/cmd overrides), and by generating the C++ modinfo.hpp from Mod/modinfo.lua during the build.
Changes:
- Added build-time generation of
src/modinfo.hppfromMod/modinfo.luaand wired it into the Injector build. - Reworked
GameJitModConfigto load/merge config from client save files or servermodoverrides.lua, plus env/cmd overrides. - Updated config schema keys (e.g.,
DisableJITWhenServer,AlwaysEnableMod) and adjusted related tooling/scripts.
Reviewed changes
Copilot reviewed 22 out of 25 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/update_steam_paths.py | Switches CMake update logic to insert/update an auto-updated GAME_DIR block. |
| tools/modinfo2cpp.lua | Generates a C++ header from modinfo.lua configuration options. |
| tools/download_frida_gum.py | Adds cache-bypass support when downloading Frida Gum (with a force flag). |
| tools/Creater/update_signatures.sh | Quotes executable paths and skips missing files. |
| tools/Creater/CMakeLists.txt | Adjusts signature update invocation paths/working directory. |
| src/modinfo.hpp | Removes the checked-in generated header (now generated during build). |
| src/DontStarveInjector/luajit_config.hpp | Removes unused fields from luajit_config. |
| src/DontStarveInjector/luajit_config.cpp | Changes JSON field names used for config serialization/deserialization. |
| src/DontStarveInjector/GameOpenGl.cpp | Reads ANGLE backend selection from GameJitModConfig. |
| src/DontStarveInjector/gameModConfig.hpp | Expands the resolved config model and declares load/write helpers. |
| src/DontStarveInjector/gameModConfig.cpp | Implements multi-source config resolution and save/modoverrides parsing/writing. |
| src/DontStarveInjector/GameLuaModule.cpp | Adds Lua table parsing/serialization helpers for config save/modoverrides I/O. |
| src/DontStarveInjector/GameLuaInjectFramework.lua | Formatting-only churn in the diff. |
| src/DontStarveInjector/game_info.cpp | Adjusts Linux game info offset scanning storage types; adds Win stub. |
| src/DontStarveInjector/DontStarveInjector.cpp | Uses GameJitModConfig for server disable logic; moves signature init earlier. |
| src/DontStarveInjector/CMakeLists.txt | Ensures Injector depends on create_modinfo_hpp. |
| Mod/modmain.lua | Writes updated config key names into luajit_config.json. |
| Mod/bin64/linux/signatures_server.json | Updates signatures and version for server. |
| Mod/bin64/linux/signatures_client.json | Updates signatures and version for client. |
| CMakeLists.txt | Adds create_modinfo_hpp custom command/target. |
| cmake/custom-triplets/x64-windows-custom.cmake | Makes VCPKG_BUILD_TYPE=release conditional for CI. |
| .gitignore | Ignores generated src/modinfo.hpp. |
| .gitattributes | Normalizes line endings by file type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…_gum.py Agent-Logs-Url: https://github.com/fesily/DontStarveLuaJIT2/sessions/a52d39d6-94f9-4add-a76f-c54b0a2f7713 Co-authored-by: fesily <15152525+fesily@users.noreply.github.com>
…module loading logic
…ression handling in PersistentString
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
args.forcetodownload_target()call so--force/-fCLI flag takes effect