Skip to content
This repository was archived by the owner on Jan 17, 2021. It is now read-only.

Conversation

@ferreiro
Copy link
Owner

@ferreiro ferreiro commented Jul 4, 2019

Huge migration to support react into the project and migrating the blog, blog post and added videos section.

Pending work:
[ ] (we can have a separate diff since new blog post should gone behind a Feature flag) Support SSR into the blog and blog post.
[X] Migrated blog home page.
[X] Migrated blog post detail page.
[ ] Make sure blog and React blog app can live together.

@ferreiro
Copy link
Owner Author

ferreiro commented Jul 4, 2019

This pull request introduces 15 alerts when merging 4705c4a into 327d721 - view on LGTM.com

new alerts:

  • 9 for Unused variable, import, function or class
  • 2 for Conflicting HTML element attributes
  • 2 for Unused or undefined state property
  • 1 for Potentially unsafe external link
  • 1 for Unsupported state update in lifecycle method

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@ferreiro ferreiro temporarily deployed to ferreiro-react-2019 July 7, 2019 16:48 Inactive
@ferreiro
Copy link
Owner Author

ferreiro commented Jul 7, 2019

This pull request introduces 16 alerts when merging 5e80c30 into 327d721 - view on LGTM.com

new alerts:

  • 10 for Unused variable, import, function or class
  • 2 for Conflicting HTML element attributes
  • 2 for Unused or undefined state property
  • 1 for Potentially unsafe external link
  • 1 for Unsupported state update in lifecycle method

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@ferreiro ferreiro temporarily deployed to ferreiro-react-2019 July 7, 2019 21:54 Inactive
@ferreiro
Copy link
Owner Author

ferreiro commented Jul 7, 2019

This pull request introduces 19 alerts when merging 762c98c into 327d721 - view on LGTM.com

new alerts:

  • 10 for Unused variable, import, function or class
  • 4 for Potentially unsafe external link
  • 2 for Conflicting HTML element attributes
  • 2 for Unused or undefined state property
  • 1 for Unsupported state update in lifecycle method

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@ferreiro ferreiro temporarily deployed to ferreiro-react-2019 July 7, 2019 22:20 Inactive
@ferreiro
Copy link
Owner Author

ferreiro commented Jul 7, 2019

This pull request introduces 21 alerts when merging deac33c into 327d721 - view on LGTM.com

new alerts:

  • 12 for Unused variable, import, function or class
  • 4 for Potentially unsafe external link
  • 2 for Conflicting HTML element attributes
  • 2 for Unused or undefined state property
  • 1 for Unsupported state update in lifecycle method

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@ferreiro ferreiro temporarily deployed to ferreiro-react-2019 July 28, 2019 03:36 Inactive
@ferreiro
Copy link
Owner Author

This pull request introduces 26 alerts and fixes 1 when merging 7eb5fb9 into 327d721 - view on LGTM.com

new alerts:

  • 18 for Unused variable, import, function or class
  • 2 for Unreachable statement
  • 2 for Unused or undefined state property
  • 1 for Identical operands
  • 1 for Conflicting HTML element attributes
  • 1 for Potentially unsafe external link
  • 1 for Unsupported state update in lifecycle method

fixed alerts:

  • 1 for Unused variable, import, function or class

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@ferreiro ferreiro temporarily deployed to ferreiro-react-2019 July 28, 2019 06:14 Inactive
@ferreiro
Copy link
Owner Author

This pull request introduces 31 alerts and fixes 1 when merging 61de1b2 into 327d721 - view on LGTM.com

new alerts:

  • 22 for Unused variable, import, function or class
  • 2 for Unreachable statement
  • 2 for Unused or undefined state property
  • 1 for Identical operands
  • 1 for Variable not declared before use
  • 1 for Conflicting HTML element attributes
  • 1 for Potentially unsafe external link
  • 1 for Unsupported state update in lifecycle method

fixed alerts:

  • 1 for Unused variable, import, function or class

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@ferreiro ferreiro temporarily deployed to ferreiro-react-2019 July 29, 2019 00:54 Inactive
@ferreiro
Copy link
Owner Author

This pull request introduces 36 alerts and fixes 1 when merging b825b1a into 327d721 - view on LGTM.com

new alerts:

  • 25 for Unused variable, import, function or class
  • 3 for Unused or undefined state property
  • 2 for Unreachable statement
  • 2 for Variable not declared before use
  • 1 for Identical operands
  • 1 for Conflicting HTML element attributes
  • 1 for Potentially unsafe external link
  • 1 for Unsupported state update in lifecycle method

fixed alerts:

  • 1 for Unused variable, import, function or class

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@ferreiro ferreiro temporarily deployed to ferreiro-react-2019 August 4, 2019 13:53 Inactive
@ferreiro
Copy link
Owner Author

ferreiro commented Aug 4, 2019

This pull request introduces 36 alerts and fixes 1 when merging 515589f into 327d721 - view on LGTM.com

new alerts:

  • 25 for Unused variable, import, function or class
  • 3 for Unused or undefined state property
  • 2 for Unreachable statement
  • 2 for Variable not declared before use
  • 1 for Identical operands
  • 1 for Conflicting HTML element attributes
  • 1 for Potentially unsafe external link
  • 1 for Unsupported state update in lifecycle method

fixed alerts:

  • 1 for Unused variable, import, function or class

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@ferreiro ferreiro temporarily deployed to ferreiro-react-2019 August 4, 2019 15:44 Inactive
@ferreiro
Copy link
Owner Author

ferreiro commented Aug 4, 2019

This pull request introduces 36 alerts and fixes 1 when merging 026e816 into 327d721 - view on LGTM.com

new alerts:

  • 25 for Unused variable, import, function or class
  • 3 for Unused or undefined state property
  • 2 for Unreachable statement
  • 2 for Variable not declared before use
  • 1 for Identical operands
  • 1 for Conflicting HTML element attributes
  • 1 for Potentially unsafe external link
  • 1 for Unsupported state update in lifecycle method

fixed alerts:

  • 1 for Unused variable, import, function or class

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@ferreiro ferreiro temporarily deployed to ferreiro-react-2019 August 4, 2019 23:34 Inactive
@ferreiro
Copy link
Owner Author

ferreiro commented Aug 4, 2019

This pull request introduces 47 alerts and fixes 1 when merging 087ddf0 into 327d721 - view on LGTM.com

new alerts:

  • 36 for Unused variable, import, function or class
  • 3 for Unused or undefined state property
  • 2 for Unreachable statement
  • 2 for Variable not declared before use
  • 1 for Identical operands
  • 1 for Conflicting HTML element attributes
  • 1 for Potentially unsafe external link
  • 1 for Unsupported state update in lifecycle method

fixed alerts:

  • 1 for Unused variable, import, function or class

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@ferreiro ferreiro temporarily deployed to ferreiro-react-2019 August 6, 2019 02:01 Inactive
@ferreiro
Copy link
Owner Author

ferreiro commented Aug 6, 2019

This pull request introduces 48 alerts and fixes 1 when merging 9794b31 into 31c9f06 - view on LGTM.com

new alerts:

  • 37 for Unused variable, import, function or class
  • 3 for Unused or undefined state property
  • 2 for Unreachable statement
  • 2 for Variable not declared before use
  • 1 for Identical operands
  • 1 for Conflicting HTML element attributes
  • 1 for Potentially unsafe external link
  • 1 for Unsupported state update in lifecycle method

fixed alerts:

  • 1 for Unused variable, import, function or class

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@ferreiro ferreiro temporarily deployed to ferreiro-react-2019 August 8, 2019 22:27 Inactive
@ferreiro
Copy link
Owner Author

ferreiro commented Aug 8, 2019

This pull request introduces 47 alerts and fixes 1 when merging 5b5e862 into 31c9f06 - view on LGTM.com

new alerts:

  • 36 for Unused variable, import, function or class
  • 3 for Unused or undefined state property
  • 2 for Unreachable statement
  • 2 for Variable not declared before use
  • 1 for Identical operands
  • 1 for Conflicting HTML element attributes
  • 1 for Potentially unsafe external link
  • 1 for Unsupported state update in lifecycle method

fixed alerts:

  • 1 for Unused variable, import, function or class

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@ferreiro ferreiro temporarily deployed to ferreiro-react-2019 October 14, 2019 21:06 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants