This repository was archived by the owner on Oct 26, 2023. It is now read-only.
Open
Conversation
|
Looks good from scrolling through the diff. @fennifith Any thoughts on this MR? |
Miepee
reviewed
Feb 14, 2022
Miepee
left a comment
Miepee
left a comment
There was a problem hiding this comment.
Regarding the MR i only have one comment.
Regarding the translation as a whole tho, I'd personally use Wecker instead of Alarm, as "Alarm" has a slightly different meaning and isn't usually associated with clocks.
|
Don't quotes |
Author
|
This says escaping is not necessary, but the quotes did not show up in the app without it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! :)
I added the missing German translations, fixed two minor mistakes and reordered the lines to match the English translation file.
I hope this can be merged :)