-
-
Notifications
You must be signed in to change notification settings - Fork 19
Update packages to latest versions #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Update usage of fengari to latest
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Due to `update-browserslist-db` command erroneously not removing the dependencies it installs, those have been removed.
What did you code review here? |
|
Admittedly, that was a "default" comment I was using for other work - I have now modified the comment to be more accurate |
|
Things seem to work fine, but I'm amazed that there weren't updates required to the webpack config.... Have you tested the resulting JS at all? Across different browsers? I was surprised to note that the new output is larger, despite needing to support far less in terms of number of browsers, and moving the license text to an external file? |
|
This has been tested by myself in Firefox, and Chrome with various configurations and use of various code including local functions, function calls, variables, arithmetic, string functions, casting and conversion of values to other types (i.e. string to int, etc), datetime, and tables. I cannot (if I'm completely honest) tell you why the newer bundle is larger, we have found this internally with a lot of our production code within our application stack as well. |
All packages updated and settings for new packages updated or created