Skip to content

Conversation

@droberts-ctrlo
Copy link

@droberts-ctrlo droberts-ctrlo commented Jan 7, 2026

All packages updated and settings for new packages updated or created

Update usage of fengari to latest
@socket-security
Copy link

socket-security bot commented Jan 7, 2026

Due to `update-browserslist-db` command erroneously not removing the dependencies it installs, those have been removed.
@daurnimator
Copy link
Member

All packages updated and code reviewed

What did you code review here?
I don't see any direct code changed in this PR; and I doubt you reviewed the full source of webpack?

@droberts-ctrlo
Copy link
Author

Admittedly, that was a "default" comment I was using for other work - I have now modified the comment to be more accurate

@daurnimator
Copy link
Member

Things seem to work fine, but I'm amazed that there weren't updates required to the webpack config....

Have you tested the resulting JS at all? Across different browsers?

I was surprised to note that the new output is larger, despite needing to support far less in terms of number of browsers, and moving the license text to an external file?

$ du -b fengari-web-v0.1.4.js dist/fengari-web.js
219632	fengari-web-v0.1.4.js
229084	dist/fengari-web.js

@droberts-ctrlo
Copy link
Author

This has been tested by myself in Firefox, and Chrome with various configurations and use of various code including local functions, function calls, variables, arithmetic, string functions, casting and conversion of values to other types (i.e. string to int, etc), datetime, and tables.

I cannot (if I'm completely honest) tell you why the newer bundle is larger, we have found this internally with a lot of our production code within our application stack as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants