feat: enable usage of csv files with wkt geometries#237
Open
feat: enable usage of csv files with wkt geometries#237
Conversation
maxnowack
requested review from
ChrisLoer,
arredond,
dnomadb,
e-n-f,
ibesora and
migurski
as code owners
Comment on lines
+474
to
+475
| \fB\fC\-z21\fR 0.4 in 1 cm 1:300 | ||
| \fB\fC\-z22\fR 0.4 in 1 cm 1:300 |
Contributor
There was a problem hiding this comment.
Why is this changed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the parsing of WKT strings (Point, LineString and Polygon) in CSV files (from columns named
geometryorwkt).I kept the original behaviour using latitude and longitude columns to ensure backwards compatibility.
I also added a new test case.
I'm a experienced developer, but more or less a rookie in c++. So please review my changes carefully.