-
Notifications
You must be signed in to change notification settings - Fork 0
Feature Contextual Action #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+830
−201
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0be3040
Feature Contextual Action
noisyneuron dfd5363
Rename and add more args
noisyneuron 492f647
rm unused
noisyneuron fbe91de
wip
noisyneuron 7470637
wip?
noisyneuron b0b875c
tweaks
noisyneuron 5c14988
tweaks
noisyneuron cc27039
tweaks
noisyneuron e2d85ef
docs(changeset): Add feature actions
noisyneuron 493a647
Fix types
tomhicks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@feltmaps/js-sdk": minor | ||
| --- | ||
|
|
||
| Add feature actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| *** | ||
|
|
||
| # Properties | ||
|
|
||
| ## action | ||
|
|
||
| > **action**: [`uiFeatureActionCreate`](uiFeatureActionCreate.md) | ||
|
|
||
| *** | ||
|
|
||
| ## placement? | ||
|
|
||
| > `optional` **placement**: \{ `after`: `string`; } | \{ `before`: `string`; } | \{ `at`: `"start"` | `"end"`; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| *** | ||
|
|
||
| # Properties | ||
|
|
||
| ## id | ||
|
|
||
| > **id**: `string` | ||
|
|
||
| *** | ||
|
|
||
| ## label? | ||
|
|
||
| > `optional` **label**: `string` | ||
|
|
||
| *** | ||
|
|
||
| ## layerIds? | ||
|
|
||
| > `optional` **layerIds**: `string`\[] | ||
|
|
||
| *** | ||
|
|
||
| ## geometryTypes? | ||
|
|
||
| > `optional` **geometryTypes**: (`"Polygon"` | `"Point"` | `"Line"` | `"Raster"`)\[] | ||
|
|
||
| *** | ||
|
|
||
| ## onTrigger()? | ||
|
|
||
| > `optional` **onTrigger**: (`args`: \{ `feature`: [`LayerFeature`](../Layers/LayerFeature.md); }) => `void` | ||
|
|
||
| ### Parameters | ||
|
|
||
| | Parameter | Type | | ||
| | -------------- | ------------------------------------------------------------ | | ||
| | `args` | \{ `feature`: [`LayerFeature`](../Layers/LayerFeature.md); } | | ||
| | `args.feature` | [`LayerFeature`](../Layers/LayerFeature.md) | | ||
|
|
||
| ### Returns | ||
|
|
||
| `void` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| *** | ||
|
|
||
| > **uiFeatureAction**: \{ `id`: `string`; `label`: `string`; `onTrigger`: (`args`: \{ `feature`: [`LayerFeature`](../Layers/LayerFeature.md); }) => `void`; `layerIds`: `string`\[]; `geometryTypes`: (`"Polygon"` | `"Point"` | `"Line"` | `"Raster"`)\[]; } | ||
|
|
||
| Represents a feature action after creation (with generated id). | ||
|
|
||
| # Type declaration | ||
|
|
||
| ## id | ||
|
|
||
| > **id**: `string` | ||
|
|
||
| ## label | ||
|
|
||
| > **label**: `string` | ||
|
|
||
| ## onTrigger() | ||
|
|
||
| > **onTrigger**: (`args`: \{ `feature`: [`LayerFeature`](../Layers/LayerFeature.md); }) => `void` | ||
|
|
||
| ### Parameters | ||
|
|
||
| | Parameter | Type | | ||
| | -------------- | ------------------------------------------------------------ | | ||
| | `args` | \{ `feature`: [`LayerFeature`](../Layers/LayerFeature.md); } | | ||
| | `args.feature` | [`LayerFeature`](../Layers/LayerFeature.md) | | ||
|
|
||
| ### Returns | ||
|
|
||
| `void` | ||
|
|
||
| ## layerIds? | ||
|
|
||
| > `optional` **layerIds**: `string`\[] | ||
|
|
||
| ## geometryTypes? | ||
|
|
||
| > `optional` **geometryTypes**: (`"Polygon"` | `"Point"` | `"Line"` | `"Raster"`)\[] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.