Skip to content

catch exceptions #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
navihtot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

catch exceptions #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions src/SoftCacheTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,12 @@ trait SoftCacheTrait {
* @param $output mixed
*/
public function writeMethodCache($method, array $args, $output) {
$cache_key = $this->getCacheKey($args);
$this->cache[$method][$cache_key] = $output;
try {
$cache_key = $this->getCacheKey($args);
Copy link
Copy Markdown
Owner

@felixmaier1989 felixmaier1989 Dec 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have getCacheKey() having its own try/catch block and return false if exception is thrown.

$this->cache[$method][$cache_key] = $output;
Copy link
Copy Markdown
Owner

@felixmaier1989 felixmaier1989 Dec 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have one test case. Could you identify which line did throw the exception you found in the logs, and then stub it like here: https://stackoverflow.com/questions/45905183/mocking-methods-to-throw-error-phpunit
You may have to move $this->cache[$method][$cache_key] = $output; to a sub function.

} catch (\Exception $e) {

}
}

/**
Expand All @@ -27,10 +31,15 @@ public function writeMethodCache($method, array $args, $output) {
* @return mixed
*/
public function readMethodCache($method, array $args) {
$cache_key = $this->getCacheKey($args);
if ($this->checkMethodCache($method, $args)) {
return $this->cache[$method][$cache_key];
try {
$cache_key = $this->getCacheKey($args);
if ($this->checkMethodCache($method, $args)) {
return $this->cache[$method][$cache_key];
}
} catch (\Exception $e) {
return false;
}

return false;
}

Expand All @@ -40,11 +49,15 @@ public function readMethodCache($method, array $args) {
* @return bool
*/
public function checkMethodCache($method, array $args) {
$cache_key = $this->getCacheKey($args);
if (!array_key_exists($method, $this->cache)) {
return false;
}
if (!array_key_exists($cache_key, $this->cache[$method])) {
try {
$cache_key = $this->getCacheKey($args);
if (!array_key_exists($method, $this->cache)) {
return false;
}
if (!array_key_exists($cache_key, $this->cache[$method])) {
return false;
}
} catch (\Exception $e) {
return false;
}
return true;
Expand Down