Update branch with main#46
Merged
felgmar merged 30 commits intoreimplement-a-gui-applicationfrom Jan 17, 2026
Merged
Conversation
* WindowsInstallerLib: refactor DeployManager class Rewrite some functions on this class to make it easier for understanding the code and thus optimizing it. * WindowsInstallerLib: refactor InstallerManager Rewrite some functions on this class to make it easier for understanding the code and thus optimizing it.
The build system should work much better with this commit. Error checking and files and folders are handled properly.
This commit makes the documentation of the library functions way better.
* Add script for downloading the installer * Add script to patch the installer * Add scripts to compile the installer * scripts: minor adjustments - Call publish-cleanup.bat before building the installer, otherwise the script won't find the files. - Set OUTPUTDIR to a more meaningful named folder. * scripts: add build-installer folder removal and improve messages
…n permissions (#43) Signed-off-by: Felipe González Martín <158048821+felgmar@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Creating the MSR partition before the EFI partition is not the default behaviour of Microsoft's installer.
- Also update old naming
- Added a separate function named AddDrivers for installing many drivers at once and AddDriver for a one .inf file at a time.
- Version 8.0 or later is required for this program to run nicely and to have official support from Microsoft, in the case of errors. Signed-off-by: Felipe González Martín <158048821+felgmar@users.noreply.github.com>
- Leftover from initial testing. Now it does what I wanted it to do.
- Yes I have used AI. This would have been a repetitive task otherwise.
Upgraded Microsoft.Dism to 3.3.12 and System.Management to 9.0.10 to ensure compatibility with latest features and bug fixes.
* WindowsInstallerLib: bump TargetFramework to .NET 10.0 * ConsoleApp: bump TargetFramework to .NET 10.0 * WindowsInstallerLib: bump version to 1.1.4.0 * ConsoleApp: bump version to 0.0.7.0
Added a default case to ArgumentParser to throw an ArgumentException when an unknown argument is encountered, improving error handling and user feedback.
Added null checks and safe closing of DismSession objects in multiple methods to prevent potential null reference exceptions and resource leaks. Improved error handling in AddDrivers by logging DismException details.
Wrapped DismApi.Initialize and DismApi.OpenOfflineSession calls in try-catch blocks to handle DismException and general exceptions explicitly. This improves robustness and error reporting during deployment operations.
Refined validation logic for destination drive format, ensuring it is exactly two characters and ends with a colon. Enhanced error handling in deployment steps to log exceptions with descriptive messages instead of rethrowing, improving user feedback during installation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.