Merged
Conversation
Replaces 'AdditionalDriversDrive' with 'AdditionalDrive' in ArgumentParser for consistency. Updates Program.cs to log exception messages instead of rethrowing, providing clearer error output during execution.
Refactored disk and driver parameter names for clarity, improved privilege checks, and streamlined user input validation in InstallerManager. Replaced DiskManager.ListAll with GetDisks to return disk info programmatically. Enhanced ProcessManager with more detailed console output during disk formatting. Separated preparation and installation logic in InstallerManager for better structure and error handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides fixing bugs and cleaning up the code some, I fixed an annoying typo I made apparently time ago when creating the EFI partition. Now the installation should be working again.