Update mongodb: 3.5.4 → 3.5.7 (patch)

[depfu]

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ mongodb (3.5.4 → 3.5.7) · Repo · Changelog

Release Notes

3.5.7

The MongoDB Node.js team is pleased to announce version 3.5.7 of the driver

Release Highlights

Warning: Accessing non-existent property 'count' of module exports inside circular dependency

Work earlier this year left some dead code in our operations code, resulting in this warning message reported by multiple users. While we still have a few cycles in our codebase yet, this will quiet Node.js 14's circular dependency warnings.

Sessions are only acquired when operations are executed

Drivers use an implicit session for all operations where an explicit session is not provided. A subtle bug was introduced when session support was implemented where implicit sessions were created and assigned to operations even if they were about to sit in a queue waiting for execution. This results in the driver creating many sessions rather than reusing pooled ones. The fix is to ensure a session is only checked out of the pool when the operation is about to be written to a server.

Thanks very much to all the community members who contributed to this release!

Release Notes

Bug

• [NODE-2536] - Circular dependency in Node.js 14 nightly
• [NODE-2552] - Server session creation grows unbounded with every operation call

Improvement

• [NODE-2534] - Document options supported by the unified topology
• [NODE-2560] - Make 'reIndex' a standalone-only command

3.5.6

The MongoDB Node.js team is pleased to announce version 3.5.6 of the driver

Release Highlights

Regression in map when cursor used as a stream

@dobesv helped identify a regression where a map function would be applied twice
if defined on a cursor, and that cursor was used to stream data.

TypeError: Cannot read property 'code' of undefined

User @linus-hologram originally reported an issue with a TypeError when the lambda
passed to the withTransaction helper rejected with a null value. @vkarpov15
submitted the fix.

readPreferenceTags interpreted as an array

A bug was fixed where readPreferenceTags with a single value in the connection
string was not properly interpreted as an array of tags. This prevented the
Use Analytics Nodes to Isolate Workload guidance from working
correctly.

Cannot set property 'isDirty' of null

User @sean-daley reported seeing this in an AWS Lambda environment, but has proven to
be somewhat of a heisenbug. We are rolling out a fix here that ensures sessions
(implicit or not) are not used after they have been explicitly ended.

Thanks very much to all the community members who contributed to this release!

Release Notes

Bug

• [NODE-2503] - Cursor ReadStream applies map function twice
• [NODE-2515] - TypeError when transaction is rejected with empty reason
• [NODE-2541] - readPreferenceTags are not interpreted as an array
• [NODE-2545] - Cannot set property 'isDirty' of null
• [NODE-2549] - Unknown topology should return empty array for server selection with read preference

3.5.5

The MongoDB Node.js team is pleased to announce version 3.5.5 of the driver

Release Highlights

Regression in hasNext when using a cursor with a limit

@peterbroadhurst helped point out a regression introduced in v3.5.4 where using hasNext
on a cusor with a limit would not return the full set of results.

Ignored topology updates cause servers to fall out of latency window

A change introduced across all MongoDB drivers, and in particular v3.5.0 of the Node.js
driver, attempted to prevent needless duplicate topologyDescriptionChanged topology events
by introducing a ServerDescription equality operator. Since equality does not take the
lastUpdateTime and lastWriteDate fields of an ismaster into account, the driver could
eventually consider servers non-suitable for server selection, since they would fall out
of the latency window.
All updates are considered viable for topology updates now, and only event emission is
gated by ServerDescription equality.

Memory leaks with Node.js v12+

The legacy topology types (in particular if you were connected to a replic set) used a
custom Timeout class to wrap a timer. Unfortunately, the class depended on an undocumented,
private variable _called, which was removed in Node.js v12. This would lead to the driver
thinking the timeout never occurred, and therefore never releasing the object for garbage
collection. We recommend users of the legacy topology types immediately update to this
version of the driver, or use the Unified Topology which is unaffected by this bug.

TypeError: Cannot read property 'Symbol(cancelled)' of undefined

@erfanium and @Paic helped us identify an issue in rare failover events where multiple
requests to process the server selection queue would result in an attempted property
access of an undefined variable.

promiseLibrary not respected by newly introduced maybePromise helper

@TobyEalden pointed out that an internal refactor to use a helper to optionally
return a Promise for top level API methods was not, in fact, using a custom
promise library if one was provided!

Thanks very much to all the community members who contributed to this release!

Release Notes

Bug

• [NODE-2460] - Memory Leak with ReplSet and NodeJS v12
• [NODE-2472] - TypeError on server available with useUnifiedTopology: true
• [NODE-2474] - Server_Description update with lastUpdateTime / lastWriteDate fields is ignored in topology
• [NODE-2480] - TypeError after reconnecting
• [NODE-2483] - Regression using hasNext on cursor with limit
• [NODE-2490] - promiseLibrary option is not honoured

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 37 commits:

• chore(release): 3.5.7
• refactor(ChangeStream): use maybePromise for next/hasNext
• docs: fix event names in gridFS tutorial
• chore: update snappy version to fix issue with node v4
• doc: document options supported by the unified topology
• test: reduce flakiness of socket timeout test
• fix: limit growth of server sessions through lazy acquisition
• fix: remove circular dependency warnings on node 14
• test: temporarily skip sharded transactions tests
• chore: update package lock to depend on latest bson version
• test: remove replicaset topology from reIndex tests
• test: lint the driver in a single evergreen task
• chore(release): 3.5.6
• chore: require bson 1.1.4 or higher
• test: wait for mock server creation before using it
• fix: only mark server session dirty if the client session is alive
• docs: Fix typo in Collection#find param
• fix: always return empty array for selection on unknown topology
• Revert "fix: createCollection only uses listCollections in strict mode"
• fix: single `readPreferenceTags` should be parsed as an array
• fix: createCollection only uses listCollections in strict mode
• fix: don't throw if `withTransaction()` callback rejects with a null reason
• chore: remove superfluous build variants
• chore: remove exotic build configurations
• fix: polyfill for util.promisify
• fix(cursor): transforms should only be applied once to documents
• chore(release): 3.5.5
• fix: multiple concurrent attempts to process the queue may fail
• fix: pass optional promise lib to maybePromise
• NODE-2474: update equal server description (#2260)
• test: ensure mock server is setup before continuing with tests
• fix: correctly use template string for connection string error message
• test: use a reduced `minHeartbeatFrequencyMS` for spec test runner
• fix(cursor): hasNext consumes documents on cursor with limit
• docs: update community links to use MongoDB Community forums
• docs: fix typo and formatting of bulletted lists
• fix: don't depend on private node api for `Timeout` wrapper

---

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@​depfu rebase

Rebases against your default branch and redoes this update

@​depfu recreate

Recreates this PR, overwriting any edits that you've made to it

@​depfu merge

Merges this PR once your tests are passing and conflicts are resolved

@​depfu close

Closes this PR and deletes the branch

@​depfu reopen

Restores the branch and reopens this PR (if it's closed)

@​depfu pause

Ignores all future updates for this dependency and closes this PR

@​depfu pause [minor|major]

Ignores all future minor/major updates for this dependency and closes this PR

@​depfu resume

Future versions of this dependency will create PRs again (leaves this PR as is)

[depfu]

Closed in favor of #135.