Modify reclaim dialog to also submit on enter press in input element#17
Open
Bortseb wants to merge 1 commit intofedwiki:masterfrom
Open
Modify reclaim dialog to also submit on enter press in input element#17Bortseb wants to merge 1 commit intofedwiki:masterfrom
Bortseb wants to merge 1 commit intofedwiki:masterfrom
Conversation
Moved the fetch to /auth/reclaim/ endpoint into form submit event, rather than dialog close event. This makes it so enter press on input element will also submit form. made cancel button close the dialog, which no longer implies trying to authenticate.
Member
WardCunningham
left a comment
WardCunningham
left a comment
There was a problem hiding this comment.
Nick and I read through these diffs and it all makes sense.
We did not actually run the code. My only worry would be that there is some difference in the dialog handling between PC and Mac.
Author
|
I only tested in chrome on Windows... So not sure, but I thought this was all using standardized dialogs/forms from html? |
Author
|
Would mac generally be the same as Linux? Maybe I can set up a virtual environment on my system for better testing? I'll test with Firefox too. |
1 similar comment
Author
|
Would mac generally be the same as Linux? Maybe I can set up a virtual environment on my system for better testing? I'll test with Firefox too. |
Member
|
Robert reports success: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the fetch to /auth/reclaim/ endpoint into form submit event, rather than dialog close event. This makes it so enter press on input element will also submit form, and try to authenticate.
made cancel button close the dialog, which no longer implies trying to authenticate.