Skip to content

fix SEARCH keyword to match by page slug#54

Merged
dobbs merged 2 commits intomainfrom
fix-search
Jan 6, 2026
Merged

fix SEARCH keyword to match by page slug#54
dobbs merged 2 commits intomainfrom
fix-search

Conversation

@dobbs
Copy link
Member

@dobbs dobbs commented Jan 6, 2026

The SEARCH keyword has not been working for me for quite a long time. I finally took the time to step through with the chrome debugger. As an educated guess, I think the miniSearch finds changed shape from whatever code came before the introduction of full text search.

In my testing without this change, any configuration for SEARCH would cause the Activity results to always be empty. After introducing this change, the SEARCH configs work as advertised in the About pages.

@dobbs
Copy link
Member Author

dobbs commented Jan 6, 2026

I was about to create a page to prove the SEARCH currently does not work. Turns out I created one back in 2024.
http://eric.dojo.fed.wiki/2024-11-10-search-activity.html

@paul90
Copy link
Member

paul90 commented Jan 6, 2026

Thanks, this looks good.

@WardCunningham
Copy link
Member

Thanks for looking into this.

@dobbs
Copy link
Member Author

dobbs commented Jan 6, 2026

I successfully published a pre-release version of this plugin (npm) and installed it with plugmatic.

Compare these views of the same page from my dojo site displayed from different origins.

In the positive case, wiki.do origin has the fix installed and the SEARCH keyword works in several configurations.
http://meta.wiki.do/eric.dojo.fed.wiki/2024-11-10-search-activity

In the negative case, dbbs.co origin does not (yet) have the fix and the SEARCH keyword does not work there.
http://wiki.dbbs.co/eric.dojo.fed.wiki/2024-11-10-search-activity

With this confirmation in place I'll merge the PR and release an official version.

@dobbs dobbs merged commit b8b04f9 into main Jan 6, 2026
3 checks passed
@dobbs dobbs deleted the fix-search branch January 6, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants