fix pageURL logic to not put double slash before slugs in some cases#53
Merged
paul90 merged 1 commit intofedwiki:mainfrom Feb 23, 2025
Merged
fix pageURL logic to not put double slash before slugs in some cases#53paul90 merged 1 commit intofedwiki:mainfrom
paul90 merged 1 commit intofedwiki:mainfrom
Conversation
Currently, if a page in an activity item's rendered body is only on a remote site, then it's href gets a double slash before the slug. This doesn't break how wiki works for some reason (if you just click the link normally), but it does break the ability to open any of those links in a new tab. I have tested this fix locally, and it seems to work in all cases. This is how hovering over links looked before:
Member
|
@Bortseb, thank you for the fix. As |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a page in an activity item's rendered body is only on a remote site, then it's href gets a double slash before the slug. This doesn't break how wiki works for some reason (if you just click the link normally), but it does break the ability to open any of those links in a new tab.
I have tested this fix locally, and it seems to work in all cases.
This is how hovering over links looked before:
And this is how they look now after my fix:
