Conversation
add other support scripts remove packages no longer needed
should be main, rather than master!
|
Now with eslint and prettier Not sure about some of the prettier configuration, not that there is much to it. Their rationale page is worth a look. I have not yet looked at the eslint output. Something to note, the size of the client shrinks from 610K to 22K as a result of the migration to JavaScript. |
- decaffeinate added declaration at lower level, which results in updates not being available when rendered.
remove `item` from parse parameters
nrn
left a comment
nrn
left a comment
There was a problem hiding this comment.
Reviewed with @WardCunningham. Lots of great changes here! Two comments to look at, but it looks good to us.
| @@ -0,0 +1,27 @@ | |||
| const gitAuthors = require('grunt-git-authors') | |||
There was a problem hiding this comment.
Good catch. Was, and still am, in two minds about using it or just keeping the authors/collaborator list up to date manually.
| @@ -1,4 +1,4 @@ | |||
| client | |||
| client/activity.* | |||
There was a problem hiding this comment.
Are we sure this fixes ignoring the source, or does it need a leading / in front?
There was a problem hiding this comment.
If there is a separator at the beginning or middle (or both) of the pattern, then the pattern is relative to the directory level of the particular .gitignore file itself. Otherwise the pattern may also match at any level below the .gitignore level.
-- gitignore documentation
2 participants
Replacing CoffeeScript with JavaScript, and updating the build process (and GitHub action).