fix(inbox): fix getting key logic #58
Conversation
for more information, see https://pre-commit.ci
Summary of ChangesHello @AmaseCocoa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug in the inbox key verification logic by enhancing the system's ability to handle diverse public key representations. The changes ensure that the signature verification process can robustly interpret and utilize public keys, whether they are provided as PEM-encoded strings, or encapsulated within Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix the logic for retrieving public keys for signature verification. The changes correctly handle more key representations, such as PEM-encoded strings and wrapper objects. However, the new key handling logic contains a flaw where it would incorrectly reject an already valid RSAPublicKey object. I've provided a critical comment with a suggested fix to make the logic more robust and correct.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
- Refactor InboxVerifier to store public keys in DER format,
simplifying
retrieval and removal of Multibase/PEM logic for cached keys.
- Move TTL logic from Cache wrapper to KeyValueStore backend.
- Enhance InMemoryKV with LRU eviction and namespace support.
- Add pytest-asyncio for asynchronous testing of caching logic.
- Include unit tests for RSA and Ed25519 key storage in DER.
for more information, see https://pre-commit.ci
|
I'd like to test this before merging since it changes the cache logic. |
resolve #55
I fixed this in going out, I review and make additional fixes after returned to home.