Add a test for the InboxVerifier.verify function

[jze]

This tests checks the HTTP signature branch of the InboxVerifier.verify function. It needs pytest-asyncio as test dependency because verify is an asynchronous function.

[gemini-code-assist]

Summary of Changes

Hello @jze, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the testing suite by introducing a dedicated test for the InboxVerifier.verify function, focusing on its ability to correctly process and validate HTTP signatures. This addition improves the reliability of the inbox verification mechanism, ensuring secure handling of signed requests. The necessary pytest-asyncio dependency has been integrated to facilitate the testing of asynchronous code paths.

Highlights

• New Test for InboxVerifier: A new test file, tests/helper/test_inbox.py, has been added to specifically test the InboxVerifier.verify function's HTTP signature branch. This test ensures that incoming ActivityPub requests with HTTP signatures are correctly validated.
• Asynchronous Test Support: The pytest-asyncio library has been introduced as a development dependency to enable testing of asynchronous functions, which is necessary for the InboxVerifier.verify function.
• Dependency Updates: The pyproject.toml and uv.lock files have been updated to include pytest-asyncio in the development dependencies, ensuring proper environment setup for running the new asynchronous tests.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[gemini-code-assist]

Code Review

This pull request adds a test for the InboxVerifier.verify function, specifically targeting the draft HTTP signature verification path. The changes include adding pytest-asyncio as a development dependency and creating a new test file with a comprehensive test case. My review focuses on improving the new test code's maintainability and adherence to Python best practices. I've suggested removing unused imports, reordering the import block for better readability, and using a more idiomatic assertion style. Overall, this is a valuable addition that increases test coverage for a critical part of the application.

[AmaseCocoa]

LGTM!