-
Notifications
You must be signed in to change notification settings - Fork 2
class ActivityPubServer moved to package apkit.server.app #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jze, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a structural refactoring within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly refactors the project by moving ActivityPubServer and SubRouter to new modules within the apkit.server package. The import statements in the documentation and examples have been updated accordingly. I have one suggestion regarding the library's import API to improve developer experience.
| from apkit.server.app import ActivityPubServer | ||
| from apkit.server.subrouter import SubRouter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While these imports are correct after the refactoring, this change highlights that imports from apkit.server are now spread across multiple submodules (app, subrouter, types, responses). To provide a cleaner public API for library users, consider exporting the main classes from the apkit.server package itself. This can be achieved by adding the relevant imports to src/apkit/server/__init__.py.
For example, in src/apkit/server/__init__.py:
from .app import ActivityPubServer
from .subrouter import SubRouter
from .types import Context, ActorKey
from .responses import ActivityResponseThis would allow users to write a single, cleaner import statement, improving the developer experience.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Thankyou! |
The
ActivityPubServerhas been moved to packageapkit.server.app. Therefore, the imports became incorrect in some places.