Skip to content

Conversation

@jze
Copy link
Contributor

@jze jze commented Jan 25, 2026

The ActivityPubServer has been moved to package apkit.server.app. Therefore, the imports became incorrect in some places.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jze, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a structural refactoring within the apkit project, specifically relocating the ActivityPubServer class to a more appropriate sub-package. This change aims to enhance the clarity and organization of the codebase. The primary impact is the necessary update of import statements across various files, including documentation and examples, to ensure all components correctly reference the moved class.

Highlights

  • Refactoring: The ActivityPubServer class has been moved from apkit.server to the more specific package apkit.server.app to improve module organization.
  • Import Updates: All references to ActivityPubServer across the README.md, documentation files (docs/index.md, docs/tutorial.md), and example code (examples/minimal_server.py) have been updated to reflect its new package location.
  • Related Import Change: The import path for SubRouter in docs/tutorial.md was also adjusted from apkit.server to apkit.server.subrouter as part of the module restructuring.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors the project by moving ActivityPubServer and SubRouter to new modules within the apkit.server package. The import statements in the documentation and examples have been updated accordingly. I have one suggestion regarding the library's import API to improve developer experience.

Comment on lines +31 to +32
from apkit.server.app import ActivityPubServer
from apkit.server.subrouter import SubRouter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While these imports are correct after the refactoring, this change highlights that imports from apkit.server are now spread across multiple submodules (app, subrouter, types, responses). To provide a cleaner public API for library users, consider exporting the main classes from the apkit.server package itself. This can be achieved by adding the relevant imports to src/apkit/server/__init__.py.

For example, in src/apkit/server/__init__.py:

from .app import ActivityPubServer
from .subrouter import SubRouter
from .types import Context, ActorKey
from .responses import ActivityResponse

This would allow users to write a single, cleaner import statement, improving the developer experience.

@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@AmaseCocoa AmaseCocoa self-assigned this Jan 25, 2026
@AmaseCocoa AmaseCocoa merged commit 94a5ade into fedi-libs:main Jan 25, 2026
7 checks passed
@AmaseCocoa
Copy link
Member

Thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants