[MERGE NOT] FECFILE-2726: move aggregation logic from db triggers to code#1877
Open
[MERGE NOT] FECFILE-2726: move aggregation logic from db triggers to code#1877
Conversation
…calculated each time.
…loop to a transaction annotation with window and bulk update.
…reate fires save.
…iling unit tests.
…m two queries per child to one.
…ce code duplication and increase readability.
…r clarity and to avoid lazy imports and import loops.
…n models.py, simple full aggration rather than complex deltas may be a mistake.
…_for_entity_contact revealed by that test.
…aled by that test.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket link:
https://fecgov.atlassian.net/browse/FECFILE-2726
Related PRs:
#1834 (Previous version using signals)
#1840 (Version prior to Todd's POC)
#1869 (Todd POC)