-
Notifications
You must be signed in to change notification settings - Fork 215
example: add new example yeahub #889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
example: add new example yeahub #889
Conversation
FSD Linter Warnings & DecisionsDuring this PR, the Feature-Sliced Design linter is enabled and reports no critical errors. Below is a list of such cases with explanations. The goal is to preserve architectural clarity and avoid degrading the project structure for the sake of formal linting compliance. 1.
|
🇷🇺 Русская версия@illright, добрый день! Буду признателен, если сможете взглянуть на этот PR. Мы считаем, что наш проект — это хороший пример крупного, реального production-проекта, который:
В проекте представлено множество реальных бизнес-сущностей и практик, характерных для enterprise-разработки:
Проект open source, и мы видим в нём высокую образовательную ценность: Будем рады, если вы рассмотрите возможность включения проекта в качестве примера в документацию FSD: Считаем, что это может стать важным шагом для сообщества и поможет лучше понять практическое применение FSD. Спасибо за ваш труд и вклад в развитие архитектуры! 🇬🇧 English version@illright, hello! I would really appreciate it if you could take a look at this PR. We believe that our project is a strong example of a large, real-world production application that:
The project includes many real-life business entities and enterprise-level patterns, such as:
The project is open source, and we see strong educational value in it: We would be happy if you consider including this project as an example in the FSD documentation: We believe this could be an important contribution to the community and help demonstrate practical usage of FSD. Thank you for your work and for developing the architecture! |
illright
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! I would personally prefer not to add new examples to the docs, but I'm willing to make an exception for projects that would make a good showcase. The one biggest point of concern I have with this project is the following:
3. Single-usage slice warnings
Warning:
This slice has only one reference in slice "...". Consider merging themRationale:
These warnings are intentionally ignored.Following this recommendation would require moving most features and widgets into the pages layer, which contradicts the principles and goals of Feature-Sliced Design.
The purpose of this project is to clearly demonstrate layer responsibility and functional ownership, not to optimize structure based on heuristic rules.
It wouldn't contradict the principles or goals of Feature-Sliced Design, in fact, it's the essence of pragmatic application of FSD and the reason why there was a minor version bump to FSD 2.1 — this is the currently preferred direction of FSD. I used to think there was value in showing an example of layer responsibility even when it's not practical, but I no longer think that. I think practicality trumps dogma and I would like the new learners of FSD to adopt this idea as well.
This point is currently a blocker for adding this project as an example. If you would be willing to reconsider your stance on this issue, I would consider adding this project. If you'd like to discuss these ideas and express your disagreement with my position, you're very welcome in our Telegram chat :)
|
@illright Could you please confirm whether it would be acceptable if we:
We would also really appreciate any additional suggestions or remarks regarding the project — we’re happy to take them into account and improve the example accordingly. Repository link: One more clarification regarding structure: pages/
Thank you in advance for your feedback! |
|
Hi @illright, We’ve created a separate branch with all the changes based on your previous feedback. Could you please take a look and let us know your thoughts? We’d really appreciate any additional suggestions or remarks to help make this project a suitable example for the documentation. Branch link: https://github.com/YeaHubTeam/yeahub-platform/tree/feature/YH-1611 Thank you in advance for your time and feedback! Best regards, |
|
Thanks, and sorry for the long response, I've been quite busy with other things lately... Your project seems to be very large, and it doesn't seem like there are any Steiger errors, great job! I'll let others from the core-team take a look at the project, and I would also suggest that you go to the Telegram chat of FSD and show this project to some people who were looking for examples — recently there have been a couple messages about that. I'm very curious about your experience refactoring your project to FSD 2.1 — do you feel like the project is easier or harder to navigate than before? |
|
Hi @illright, Thank you for your kind words and for developing FSD — we really appreciate the work the team is doing. We actively use FSD in our projects and also try to popularize the approach, as we want it to be more accessible and understandable for both beginners and experienced developers. Our goal is to make this project a solid real-world example of using FSD in a large codebase. We want it to be useful not only as a reference, but also as a learning resource. We’ll also think about writing an article describing our experience in more detail. Regarding your question about refactoring to FSD 2.1 — we’ll prepare a more detailed response. We plan to outline what was challenging during the migration, what trade-offs we encountered, and what the refactoring ultimately led to in terms of project structure and navigation. Thanks again for your feedback and interest in the project! |
Background
This update adds YeaHub Platform as a new example — a large-scale production project that demonstrates:
The project brings significant value to the community by serving as:
Description
YeaHub Platform is a professional IT community platform built as a production-ready application with a complete FSD architecture.
Tech Stack
Core
State Management
Routing
UI
Infrastructure
FSD Implementation Features
Links