Add lazy binary download on first CLI run #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python: - Auto-download Go binary from GitHub releases when not found - Fixes pip wheel install not triggering post-install hooks - Add proper stdout flushing for download progress messages npm: - Read version from package.json instead of hardcoding - Add lazy download fallback to CLI wrapper - Export downloadBinary for reuse Both packages bumped to version 0.1.8
feat7
force-pushed
the
fix/python-lazy-download
branch
from
d144dd8 to
5d49f82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where
pip install ingestkitandnpm install ingestkitdon't always download the Go binary (pip wheels bypass post-install hooks, npm --ignore-scripts skips postinstall).Changes
Python
npm
.gitignore
Test Plan
ingestkit --help- downloads and works