Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a74a7add7e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fetch_latest_tag() { | ||
| local response tag | ||
| local -a headers | ||
| mapfile -t headers < <(curl_headers) |
There was a problem hiding this comment.
The wrapper now claims macOS support, but it uses mapfile to build curl headers; mapfile is not available in the default Bash 3.2 shipped on macOS, so ./scripts/fe exits with mapfile: command not found before it can download or run Fe. This affects contributors (and any CI) on stock macOS setups unless they manually install a newer Bash, so the new cross-platform path is effectively broken in that environment.
Useful? React with 👍 / 👎.
| temp_check_file="$TEMP_DIR/standalone_$(basename "$fe_file")" | ||
| prepare_standalone_check_file "$fe_file" "$temp_check_file" | ||
| FE_OUTPUT=$("$SCRIPT_DIR/fe" check "$temp_check_file" 2>&1) || true |
There was a problem hiding this comment.
Standalone examples are now checked through a generated temp file with boilerplate prepended, so any compiler diagnostics reference shifted line numbers in that synthetic file instead of the original src/examples/*.fe source. When a standalone example fails, the reported location is therefore misleading, which makes CI failures harder to triage and fix; this path should either check the original file directly or remap diagnostics back to original line numbers.
Useful? React with 👍 / 👎.
cburgdorf
force-pushed
the
example_check
branch
from
cceb4b9 to
fd66a63
Compare
1 participant
No description provided.